Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request ##3947-Replaced-URL-of-New-Twitter-App to master. #3952

Merged
merged 20 commits into from
Apr 22, 2020

Conversation

AmTryingMyBest
Copy link
Contributor

@AmTryingMyBest AmTryingMyBest commented Apr 22, 2020

This pull request makes the following changes:

  • Replaced URL of new Twitter App to correct URL.

Test checklist:

  • Check that URL for how to create new twitter application has been updated to (...apps/create)

  • I certify that I ran my checklist

Fixes ushahidi/platform# .

Ping @ushahidi/platform

rowasc and others added 20 commits April 9, 2020 23:48
…/{userid}/status/{tweetId}

- This change was necessary because the old /statuses path stopped working at some point, which means all the twitter urls we grabbed from that point onwards were broken. Not super great
- There doesn't seem to be any way to get the correct URL from the API response we get from /search API, which is very dissapointing because if the format changes again this will stop working. The only thing that saves us here is that because this is a more user facing url, its likely that it will be redirected even if it changes, rather than just stop working
fix(Twitter): urls are now formatted with the std https://twitter.com…
Revert "fix(Twitter): urls are now formatted with the std https://twitter.com…"
Replaced URL of new Twitter App.
@AmTryingMyBest AmTryingMyBest merged commit ee5d9f7 into master Apr 22, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 20.287% when pulling 169b553 on develop into 23595af on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants