fix(Twitter): urls are now formatted with the std https://twitter.com… #3925
Conversation
…/{userid}/status/{tweetId} - This change was necessary because the old /statuses path stopped working at some point, which means all the twitter urls we grabbed from that point onwards were broken. Not super great - There doesn't seem to be any way to get the correct URL from the API response we get from /search API, which is very dissapointing because if the format changes again this will stop working. The only thing that saves us here is that because this is a more user facing url, its likely that it will be redirected even if it changes, rather than just stop working
| */ | ||
| public function change() | ||
| { | ||
| $sql = "UPDATE messages |
There was a problem hiding this comment.
I had to do replace rather than set because I wanted to play it safe in case there is some scenario where message doesn't conform with just having a single tweet as the content and has other content that we shouldn't just erase with a SET
Light concern: this change should be fine, but it may be pretty heavy in some deployments... like my ridiculous testing one with like 300k tweeets ...
| * API itself in the v1.1 search endpoint. | ||
| * Fun fact: if the user id is wrong, twitter still takes you to the correct Tweet... they just use the tweet id | ||
| **/ | ||
| 'message' => "https://twitter.com/$user_id/status/$id", |
There was a problem hiding this comment.
couldn't find a way to get twitter urls... so I'm using this more obvious user facing URL instead of /statuses... which I suppose gives me more peace of mind... but still, would prefer if twitter actually gave us the url to use, you know?
|
@tuxpiper this is medium-gross, but there wasn't a good way to get the URL so I suppose is the best we can do right now (unless we figure out a better way ? lol). Not super happy about the fact that this may become broken if twitter decides to deprecate this url format without redirects like they did for /statuses tho |
| { | ||
| $sql = "UPDATE messages | ||
| INNER JOIN contacts on contacts.id = messages.contact_id | ||
| SET messages.message = REPLACE(messages.message, concat('https://twitter.com/statuses/', messages.data_source_message_id), concat('https://twitter.com/', contacts.contact, '/status/', messages.data_source_message_id)) |
There was a problem hiding this comment.
I thought this couldn't be done, because when I was checking a database with tweet messages, I couldn't see the tweet user handles anywhere. Turns out that we are storing the numeric ID for the user.
It also turns out that twitter at this point in time now will accept that numeric ID in the tweet URL (i.e. https://twitter.com/:userNumId/status/:tweetId ) and redirect to the URL with the user handle.
So that's good now, it makes me queasy though 🤷 Should we start storing the screen name, should we start storing both? Big questions for a Friday
|
@rowasc only new tweets coming in have working links. |
|
@Obadha2 oh that's unfortunate :/ Checking |
|
@Obadha2 which deployment did you use? just so I go into it |
…/{userid}/status/{tweetId}
This pull request makes the following changes:
Test checklist
BEFORE you merge this PR, ensure that you
After you merge this PR and it lands in steve
@Obadha2 this is important for context see above the checklist
Fixes ushahidi/platform# .
Ping @ushahidi/platform