fix(Twitter): urls are now formatted with the std https://twitter.com… #3925
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| <?php | ||
|
|
||
| use Phinx\Migration\AbstractMigration; | ||
|
|
||
| class RewriteTwitterUrls extends AbstractMigration | ||
| { | ||
| /** | ||
| * Change Method. | ||
| * | ||
| * Write your reversible migrations using this method. | ||
| * | ||
| * More information on writing migrations is available here: | ||
| * http://docs.phinx.org/en/latest/migrations.html#the-abstractmigration-class | ||
| * | ||
| * The following commands can be used in this method and Phinx will | ||
| * automatically reverse them when rolling back: | ||
| * | ||
| * createTable | ||
| * renameTable | ||
| * addColumn | ||
| * renameColumn | ||
| * addIndex | ||
| * addForeignKey | ||
| * | ||
| * Remember to call "create()" or "update()" and NOT "save()" when working | ||
| * with the Table class. | ||
| */ | ||
| public function up() | ||
| { | ||
| $sql = "UPDATE messages | ||
| INNER JOIN contacts on contacts.id = messages.contact_id | ||
| SET messages.message = REPLACE(messages.message, concat('https://twitter.com/statuses/', messages.data_source_message_id), concat('https://twitter.com/', contacts.contact, '/status/', messages.data_source_message_id)) | ||
|
There was a problem hiding this comment. I thought this couldn't be done, because when I was checking a database with tweet messages, I couldn't see the tweet user handles anywhere. Turns out that we are storing the numeric ID for the user. It also turns out that twitter at this point in time now will accept that numeric ID in the tweet URL (i.e. https://twitter.com/:userNumId/status/:tweetId ) and redirect to the URL with the user handle. So that's good now, it makes me queasy though 🤷 Should we start storing the screen name, should we start storing both? Big questions for a Friday |
||
| WHERE `messages`.`type` = 'twitter'"; | ||
| $this->execute($sql); | ||
| } | ||
|
|
||
| public function down() { | ||
| $sql = "UPDATE messages | ||
| INNER JOIN contacts on contacts.id = messages.contact_id | ||
| SET messages.message = REPLACE(messages.message, concat('https://twitter.com/', contacts.contact, '/status/', messages.data_source_message_id), concat('https://twitter.com/statuses/', messages.data_source_message_id)) | ||
| WHERE `messages`.`type` = 'twitter'"; | ||
| $this->execute($sql); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to do replace rather than set because I wanted to play it safe in case there is some scenario where message doesn't conform with just having a single tweet as the content and has other content that we shouldn't just erase with a SET
Light concern: this change should be fine, but it may be pretty heavy in some deployments... like my ridiculous testing one with like 300k tweeets ...