Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced URL of new Twitter App. #3947

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Conversation

noone0212
Copy link
Contributor

This pull request makes the following changes:

  • Replaced URL of new Twitter App to correct URL.

Test checklist:

  • [ ]

  • I certify that I ran my checklist

Fixes #3932 .

Ping @ushahidi/platform

@ushbot
Copy link
Collaborator

ushbot commented Apr 21, 2020

Hey @noone0212,
thank you for your Pull Request.

It looks like you haven't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@noone0212
Copy link
Contributor Author

clabot:check

@coveralls
Copy link

coveralls commented Apr 21, 2020

Coverage Status

Coverage remained the same at 20.287% when pulling 914ca2c on noone0212:url-change into f6cb692 on ushahidi:develop.

Copy link
Contributor

@rowasc rowasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @noone0212 ! avoids the redirect warning that twitter does for the old url 💯

@AmTryingMyBest AmTryingMyBest merged commit 169b553 into ushahidi:develop Apr 22, 2020
@AmTryingMyBest
Copy link
Contributor

QA'd, passes. 👍

AmTryingMyBest added a commit that referenced this pull request Apr 22, 2020
Merge pull request ##3947-Replaced-URL-of-New-Twitter-App to master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The link to create a new Twitter-app is wrong
5 participants