Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #3937-address-regression-with-handling-posts to master. #3944

Merged
merged 21 commits into from
Apr 20, 2020

Conversation

AmTryingMyBest
Copy link
Contributor

@AmTryingMyBest AmTryingMyBest commented Apr 20, 2020

This pull request makes the following changes:

Test checklist:

  • Go to survey with two location fields.

  • Make sure one of the fields is required.

  • Fill in the survey.

  • Publish the response.

  • Ensure the response is published and has status changed from Under Review to Published.

  • I certify that I ran my checklist

Fixes ushahidi/platform# .

Ping @ushahidi/platform

tuxpiper and others added 21 commits April 1, 2020 17:06
thanks to @leninpaulino

Co-Authored-By: Lenin Paulino <leninpaulinon@gmail.com>
perf(posts): save some of the multiple db queries performed to fetch …
fix(post-entity): address regression with handling posts when forms h…
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 20.287% when pulling 3037be1 on develop into 460a186 on master.

@rowasc rowasc merged commit 5f94846 into master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants