Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: gateway checker second try #3911

Merged
merged 2 commits into from
Apr 8, 2020
Merged

test: gateway checker second try #3911

merged 2 commits into from
Apr 8, 2020

Conversation

individual-it
Copy link
Contributor

This pull request makes the following changes:

  • added tests for gateway checker

this is the second try, because the first broke CI on codeship and had to be reverted see #3880 (review)
DOCUMENT_ROOT & SCRIPT_FILENAME are now looking out for httpdocs and not platform. That should not make any big difference for the quality of the tests, we just want to make sure there is something sensible in those fields, and that way it should pass on more different platforms

Test checklist:

  • 🤖

  • I certify that I ran my checklist

Fixes #3672 .

Ping @ushahidi/platform

@individual-it
Copy link
Contributor Author

CC @tuxpiper @rowasc

@individual-it individual-it mentioned this pull request Apr 3, 2020
2 tasks
@coveralls
Copy link

coveralls commented Apr 3, 2020

Coverage Status

Coverage remained the same at 20.309% when pulling a51ac18 on individual-it:test-gwcheck2 into 02e371e on ushahidi:develop.

@rowasc rowasc merged commit 37605ed into ushahidi:develop Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Gateway Checker – add automated tests
3 participants