Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to publish post if there are two location fields, one of the fields being required. #3922

Closed
AmTryingMyBest opened this issue Apr 9, 2020 · 10 comments · Fixed by #3937

Comments

@AmTryingMyBest
Copy link
Contributor

Describe the bug
If a survey has more than one location field, and one of the location fields is a required field, a post submitted to this post can't be published.

Where was the bug observed
Deployment - https://test-deployment.steve-buscemi.ush.zone/views/map

To Reproduce
Steps to reproduce the behavior:

  1. Go to deployment.
  2. Create survey with two location fields, make one of the fields as required.
  3. Go to Data view, and add a post to this survey.
  4. Fill in both location fields.
  5. Save this post.
  6. Change the status of this post to Published.
  7. Publishing fails with error (see attached screenshot)

Expected behavior
Posts should be publishable once all required fields are provided.

Is there a workaround? What is it.
None.

Screenshots
Screenshot 2020-04-09 at 12 27 54 PM

URL / Environment where this happened
https://test-deployment.steve-buscemi.ush.zone/posts/6089

Desktop Hardware Details (please complete the following information):

  • OS: iOS
  • Browser: chrome
  • Version: 80.0.3987.163
@rowasc
Copy link
Contributor

rowasc commented Apr 14, 2020

@Obadha2 Why isn't this a blocker? is it a regression or not?

@rowasc
Copy link
Contributor

rowasc commented Apr 14, 2020

I just checked, this IS a regression, since I cannot make it happen in production, or maybe I'm doign something wrong.
@tuxpiper @Obadha2 please let me know why this was not seen as a blocker/if I'm missing something?

@tuxpiper
Copy link
Member

tuxpiper commented Apr 15, 2020

mm bummer..

It was my estimation that it wouldn't be a regression, given that it was a newly introduced test and how wonky the behavior is in other places when the form has two location fields.

On the other hand, I think we may be pushing the envelope here, compared to the typical use of platform. The code is not well prepared for handling the case of 2+ locations in a form, but we haven't gotten bug reports other than from our own testing.

@rowasc
Copy link
Contributor

rowasc commented Apr 15, 2020

@tuxpiper not sure what you mean pushing the envelope? (sorry!)
And yes support is bad for multi location, but preventing publishing is badder 🤔
@Obadha2 really curious to hear if this is something you verified in production to make this call because it may just be that I'm having trouble with it. Please let me know.

@AmTryingMyBest
Copy link
Contributor Author

@rowasc this isn't happening in prod, so it's new. I think we decided this wasn't a blocker since we saw the odds of having more than one location field in one survey as minimal so we thought this wouldn't block or get in the way of regular use of the platform.

@rowasc
Copy link
Contributor

rowasc commented Apr 15, 2020

ok thanks @Obadha2
@tuxpiper can you work on a fix and let us know so we can release without the regression? 😬
Thanks

@tuxpiper
Copy link
Member

warming up gross hack generator cannon
aiming cannon to already gross codebase
no problem, just leave it to me 👍

@tuxpiper
Copy link
Member

@rowasc fix PR posted : #3937

@tuxpiper
Copy link
Member

note that things like fetching geojson will be slow again , when the form contains 2 location fields

@AmTryingMyBest
Copy link
Contributor Author

QA'd, passes. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants