-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace site decided with new site address question #7486
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data-hub-frontend
|
Project |
data-hub-frontend
|
Branch Review |
feature/CLS2-1175-site-address-changes
|
Run status |
|
Run duration | 01m 39s |
Commit |
|
Committer | Oliver Roberts |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
15
|
View all changes introduced in this branch ↗︎ |
Co-authored-by: Stuart Mindt <stuart.mindt@madetech.com>
4f0bc76
to
ccd48a4
Compare
Also removes two investment project fixtures in favour of fakers.
ccd48a4
to
868e38b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7486 +/- ##
==========================================
- Coverage 88.57% 88.55% -0.03%
==========================================
Files 1144 1144
Lines 17789 17792 +3
Branches 5097 5099 +2
==========================================
- Hits 15757 15756 -1
- Misses 2032 2036 +4 ☔ View full report in Codecov by Sentry. |
2 tasks
dredmonds
approved these changes
Jan 29, 2025
DeanElliott96
approved these changes
Jan 29, 2025
chopkinsmade
pushed a commit
that referenced
this pull request
Jan 30, 2025
generated from commit 382debc
oliverjwroberts
added a commit
that referenced
this pull request
Jan 30, 2025
This reverts commit 382debc.
3 tasks
oliverjwroberts
added a commit
that referenced
this pull request
Jan 30, 2025
chopkinsmade
pushed a commit
that referenced
this pull request
Jan 30, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR replaces the current
site_decided
question with a newsite_address_is_company_address
question on the project edit requirement form. It also removes theactual_uk_regions
field.Test instructions
For projects that have:
site_address_is_company_address === null
: the radio buttons should be unselected. If no modifications are made, the frontend will set the address fields to empty strings (as this was the existing behaviour);site_address_is_company_address === true && !uk_company)
: the yes option will be selected and show some help text prompting users to select a UK recipient company. Upon submission, the frontend will setsite_address_is_company_address === true
the address fields to empty strings.site_address_is_company_address === true && uk_company)
: the yes option will be selected and show the Uk recipient company address fields. Upon submission, the frontend will setsite_address_is_company_address === true
the address fields to the UK company address.site_address_is_company_address === false
: the no option will be selected and address fields will appear for manual entry. Upon submission, the frontend will setsite_address_is_company_address === false
the address fields to the values entered.Screenshots
Before
The
site_decided
field when Yes is selected:The
site_decided
field when No is selected:The incomplete fields flash message:
After
The
site_address_is_company_address
field when Yes is selected, but the project does not have auk_company
:The
site_address_is_company_address
field when Yes is selected and the project has auk_company
:The
site_address_is_company_address
field when No is selected:The incomplete fields flash message:
Checklist