-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stage validation for site_address_is_company_address
field
#5928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also modify validation for site address fields. These are now only required if `site_address_is_company_address` is not None.
586e385
to
ad305ea
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5928 +/- ##
=======================================
Coverage 96.67% 96.67%
=======================================
Files 1070 1070
Lines 25382 25385 +3
Branches 1672 1672
=======================================
+ Hits 24538 24541 +3
Misses 689 689
Partials 155 155 ☔ View full report in Codecov by Sentry. |
dredmonds
approved these changes
Jan 29, 2025
DeanElliott96
approved these changes
Jan 29, 2025
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR adds validation for the
site_address_is_company_address
field; which is now required at the Verify Win stage.Important
This supports changes being made to the site address question in the project edit requirements form - see FE PR #7486 here.
It also modifies the validation for the site address fields. These are now only required if
site_address_is_company_address
is not None.For projects at the active (and subsequent) stage(s), the API will send the
site_address_is_company_address
andaddress_*
fields in theproject.incomplete_fields
list. The frontend then uses this list to highlight incomplete fields to the user.Checklist
Has this branch been rebased on top of the current
main
branch?Explanation
The branch should not be stale or have conflicts at the time reviews are requested.
Is the CircleCI build passing?
General points
Other things to check
fixtures/test_data.yaml
is maintained when updating modelsSee docs/CONTRIBUTING.md for more guidelines.