Reapply site address question changes with some modifications

[oliverjwroberts]

Description of change

Reapplies PR #7486 (commit 382debc) with some modifications. These include:

• keeping the actual_uk_regions question and unnesting it
• setting the address fields to the existing/entered values when (site_address_is_company_address == True && uk_company is not None) is False

Updated API PR can be found here.

Test instructions

For projects that have:

• site_address_is_company_address === null: the radio buttons should be unselected. If no modifications are made, the frontend will set the address fields to existing values upon submission.
• site_address_is_company_address === true && !uk_company): the yes option will be selected and show some help text prompting users to select a UK recipient company. Upon submission, the frontend will set site_address_is_company_address === true the address fields to existing values.
• site_address_is_company_address === true && uk_company): the yes option will be selected and show the UK recipient company address fields. Upon submission, the frontend will set site_address_is_company_address === true the address fields to the UK company address.
• site_address_is_company_address === false: the no option will be selected and address fields will appear for manual entry. Upon submission, the frontend will set site_address_is_company_address === false and the address fields to the values entered.

The actual_uk_regions field is now separate/unnested and should behave as usual.

Screenshots

Checklist

• Has the branch been rebased to main?
• Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
• Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

[cypress]

data-hub-frontend    Run #59124

Run Properties:   Passed #59124  •  e8ab959904: Test transformation of actual_uk_regions field

Project	data-hub-frontend
Branch Review	feature/CLS2-1175-site-address-field-changes
Run status	Passed #59124
Run duration	08m 05s
Commit	e8ab959904: Test transformation of actual_uk_regions field
Committer	Oliver Roberts
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	4
Skipped	0
Passing	74
View all changes introduced in this branch ↗︎

[codecov]

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.57%. Comparing base (e4b0ea2) to head (e8ab959).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...dules/Investments/Projects/Details/transformers.js	87.50%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7511   +/-   ##
=======================================
  Coverage   88.57%   88.57%           
=======================================
  Files        1144     1144           
  Lines       17789    17798    +9     
  Branches     5097     5105    +8     
=======================================
+ Hits        15756    15765    +9     
  Misses       2033     2033           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cgsunkel]

Feel free to disregard the comment if you know it won't work like that

[DeanElliott96]

LGTM, for the parts in the transformers that coverage highlighted, are they missing tests? Could a unit test be added for them?

[oliverjwroberts]

LGTM, for the parts in the transformers that coverage highlighted, are they missing tests? Could a unit test be added for them?

Good spot.

I would argue

  if (siteAddressIsCompanyAddressBool === true && ukCompany) {
    return {

is covered by

it('should submit site address is company address is true and populate address fields when user selects yes and project has uk company', () => {

In regards to the other missed line, I've added a test for the actual_uk_regions field transformation.