-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCPP updates: UGWPv1 decomp bug fixes, remove Julie from CODEOWNERS; bug fix in tests/run_compile.sh #835
CCPP updates: UGWPv1 decomp bug fixes, remove Julie from CODEOWNERS; bug fix in tests/run_compile.sh #835
Conversation
Automated RT Failure Notification |
Both jobs hang right at the beginning, a slurm issue? Will recover the regression test log file, rerun those two jobs manually, append to the log file and commit. |
Automated RT Failure Notification |
Timeout ... and somehow a weird message about out of memory. Something to keep in mind, just in case this happens again:
EDIT: This was the baseline creation step, and everything is under @BrianCurtis-NOAA's user/permissions ... will create baseline again, manually ... |
So auto-RT works on orion because nothing needs to be moved, but auto-BL does not work on orion, correct? |
Well, the one test failed because of a timeout, but I couldn't access the remaining baseline that was created under Brian's stmp directory. Otherwise I would have copied that, rerun only the one job to create the missing baseline, and then verify against it. Now I had to create the entire baseline again. |
fv3atm hash correct, ready to merge |
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Description
Update submodule pointer for fv3atm for the changes described in the associated PRs below:
CODEOWNERS
files in both ccpp-framework and ccpp-physics.See NCAR/ccpp-physics#728 for a detailed description of the UGWPv1 updates.
Also: bug fix in
tests/run_compile.sh
to correctly catch failed compile jobs (e.g. when the disk runs full) from @DusanJovic-NOAANo new input data required, but the results for the following regression tests will change:
These baseline changes are expected, because all of these tests utilize UGWPv1.
Issue(s) addressed
Fixes #742
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies