CCPP updates: UGWPv1 decomp bug fixes, remove Julie from CODEOWNERS; …

…bug fix in tests/run_compile.sh (#835) * Bug fix in tests/run_compile.sh to correctly detect failed compile jobs * Fix permissions for tests/run_compile.sh * Substantial changes in UGWPv1 to fix problem of lack of reproducibility when changing the domain decomposition layout. Remove Julie from CODEOWNERS files in both ccpp-framework and ccpp-physics. See NCAR/ccpp-physics#728 for a detailed description of the UGWPv1 updates.
ufs-community · Sep 29, 2021 · 3e5cac8 · 3e5cac8
1 parent 5530c28
commit 3e5cac8
Show file tree

Hide file tree

Showing 12 changed files with 2,741 additions and 2,769 deletions.
diff --git a/FV3 b/FV3
diff --git a/tests/RegressionTests_cheyenne.gnu.log b/tests/RegressionTests_cheyenne.gnu.log
diff --git a/tests/RegressionTests_cheyenne.intel.log b/tests/RegressionTests_cheyenne.intel.log
diff --git a/tests/RegressionTests_gaea.intel.log b/tests/RegressionTests_gaea.intel.log
diff --git a/tests/RegressionTests_hera.gnu.log b/tests/RegressionTests_hera.gnu.log
diff --git a/tests/RegressionTests_hera.intel.log b/tests/RegressionTests_hera.intel.log
diff --git a/tests/RegressionTests_jet.intel.log b/tests/RegressionTests_jet.intel.log
diff --git a/tests/RegressionTests_orion.intel.log b/tests/RegressionTests_orion.intel.log
diff --git a/tests/RegressionTests_wcoss_cray.log b/tests/RegressionTests_wcoss_cray.log
diff --git a/tests/RegressionTests_wcoss_dell_p3.log b/tests/RegressionTests_wcoss_dell_p3.log
diff --git a/tests/rt.sh b/tests/rt.sh
@@ -444,7 +444,7 @@ if [[ $TESTS_FILE =~ '35d' ]]; then
   TEST_35D=true
 fi
 
-BL_DATE=20210924
+BL_DATE=20210928
 if [[ $MACHINE_ID = hera.* ]] || [[ $MACHINE_ID = orion.* ]] || [[ $MACHINE_ID = cheyenne.* ]] || [[ $MACHINE_ID = gaea.* ]] || [[ $MACHINE_ID = jet.* ]] || [[ $MACHINE_ID = s4.* ]]; then
   RTPWD=${RTPWD:-$DISKNM/NEMSfv3gfs/develop-${BL_DATE}/${RT_COMPILER^^}}
 else

diff --git a/tests/run_compile.sh b/tests/run_compile.sh
@@ -4,6 +4,7 @@ set -eux
 echo "PID=$$"
 SECONDS=0
 
+trap '[ "$?" -eq 0 ] || write_fail_test' EXIT
 trap 'echo "run_compile.sh interrupted PID=$$"; cleanup' INT
 trap 'echo "run_compile.sh terminated PID=$$";  cleanup' TERM
 
@@ -13,6 +14,14 @@ cleanup() {
   exit
 }
 
+write_fail_test() {
+  if [[ ${UNIT_TEST} == true ]]; then
+    echo compile ${COMPILE_NR} >> $PATHRT/fail_unit_test
+  else
+    echo "compile_${COMPILE_NR} failed in run_compile" >> $PATHRT/fail_test
+  fi
+  exit 1
+}
 
 if [[ $# != 4 ]]; then
   echo "Usage: $0 PATHRT RUNDIR_ROOT MAKE_OPT COMPILE_NR"
@@ -62,6 +71,8 @@ else
   ./job_card
 fi
 
+ls -l ${PATHTR}/tests/fv3_${COMPILE_NR}.exe
+
 cp ${RUNDIR}/compile_*_time.log ${LOG_DIR}
 cat ${RUNDIR}/job_timestamp.txt >> ${LOG_DIR}/job_${JOB_NR}_timestamp.txt
 ################################################################################