fixed issue with decomp-change RT failures with ugwpv1 and made other… #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
reviewed
Sep 13, 2021
There was a problem hiding this comment.
Looks good to me, definitely makes sense to not rely on the first grid column the way the code was written. You could have use global mpi comm to get a mean dx at initialization and use this throughout, but as your comments in the code said would require the mean to be representative for all grid columns.
yangfanglin
reviewed
Sep 13, 2021
| @@ -908,8 +908,8 @@ subroutine orogw_v1 (im, km, imx, me, master, dtp, kdt, do_tofd, & | |||
| dudt_obl(j,k) = -dbim * u1(j,k) | |||
| dvdt_obl(j,k) = -dbim * v1(j,k) | |||
|
|
|||
| pdvdt(j,k) = dudt_obl(j,k) +pdvdt(j,k) | |||
| pdudt(j,k) = dvdt_obl(j,k) +pdudt(j,k) | |||
| pdudt(j,k) = dudt_obl(j,k) +pdudt(j,k) | |||
There was a problem hiding this comment.
Mike, are pdudt and pdvdt diagnostics ? Does this bug have any impact on forecast ?
|
Fanglin,
The bug in physics/cires_ugwpv1_oro.F90 would have an impact on the forecast only if using Valery’s UGWPv1 orographic drag. The P7 doesn’t use this scheme, but instead uses the GSL orographic drag.
The bugfixes in drag_suite.F90 would have an effect on the forecast.
— Mike
… On Sep 13, 2021, at 1:26 PM, Fanglin Yang ***@***.*** ***@***.***>> wrote:
@yangfanglin commented on this pull request.
Mike, does the updates (except for the bug fixes) change forecasts ?
In physics/cires_ugwpv1_oro.F90 <#728 (comment)>:
> @@ -908,8 +908,8 @@ subroutine orogw_v1 (im, km, imx, me, master, dtp, kdt, do_tofd, &
dudt_obl(j,k) = -dbim * u1(j,k)
dvdt_obl(j,k) = -dbim * v1(j,k)
- pdvdt(j,k) = dudt_obl(j,k) +pdvdt(j,k)
- pdudt(j,k) = dvdt_obl(j,k) +pdudt(j,k)
+ pdudt(j,k) = dudt_obl(j,k) +pdudt(j,k)
Mike, are pdudt and pdvdt diagnostics ? Does this bug have any impact on forecast ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#728 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFMODLEKJUFLH7K64Y2SNVTUBZF7TANCNFSM5D3QI7FQ>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
14 tasks
junwang-noaa
pushed a commit
to ufs-community/ufs-weather-model
that referenced
this pull request
Sep 29, 2021
…bug fix in tests/run_compile.sh (#835) * Bug fix in tests/run_compile.sh to correctly detect failed compile jobs * Fix permissions for tests/run_compile.sh * Substantial changes in UGWPv1 to fix problem of lack of reproducibility when changing the domain decomposition layout. Remove Julie from CODEOWNERS files in both ccpp-framework and ccpp-physics. See NCAR/ccpp-physics#728 for a detailed description of the UGWPv1 updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drag_suite.F90:
Substantial changes to fix problem of lack of reproducibility when changing the domain decomposition layout. Basically, the problem was that the "scale aware" feature used the grid size "dx" at one representative point, i.e., dx(1). This would of course vary depending on the domain decomposition. The code was changed to test the value of "dx" at every grid point. Associated with this change, the dimensionality of the following variables was changed:
Instead of multiple loops over i, there is now only one loop over i per drag component, i.e., large-scale+blocking, ssGWD and form drag.
There was also a bug found in the semi-implicit time step treatment of the v-wind component of the SSGWD. This was fixed.
cires_ugwpv1_oro.F90:
Fixed a bug in the calculation of the pdudt and pdvdt tendencies.
ugwpv1_gsldrag.F90:
Fixed a bug in the if-then logic beginning on line 536. Changed "else" on line 584 to "endif". The problem was that with the "else" statement, it was impossible to combine the small-scale GSL drag schemes (SSGWD and form drag) with the ugwpv1 orog_only drag scheme.