Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the warm bias in stratosphere from MERRA2 coupled microphysics #1788

Closed
wants to merge 10 commits into from
Closed

Fixed the warm bias in stratosphere from MERRA2 coupled microphysics #1788

wants to merge 10 commits into from

Conversation

AnningCheng-NOAA
Copy link
Contributor

@AnningCheng-NOAA AnningCheng-NOAA commented Jun 5, 2023 •
edited by jkbk2004
Loading

Description

Input data additions/changes

  • No changes are expected to input data.
  • Changes are expected to input data:
  • New input data.
  • Updated input data.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests: merra2_thompson

RegressionTests_hera.log

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved in section below
  • Confirm reviews completed in ALL sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne AND attach log to a PR comment.
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

This was referenced Jun 5, 2023
Closed
Closed
@grantfirl
Copy link
Collaborator

@AnningCheng-NOAA Please do the same procedure I outlined in your FV3 PR to point this to your PR branch of fv3atm. Please revert the changes to rt.conf. Also, UFS code managers want your log file to be attached to the comments, not pushed to the repo. Plus, the log file that you pushed doesn't show a completed RT session.

@AnningCheng-NOAA
Copy link
Contributor Author

AnningCheng-NOAA commented Jun 7, 2023 via email

@AnningCheng-NOAA
Copy link
Contributor Author

AnningCheng-NOAA commented Jun 9, 2023 via email

DeniseWorthen
DeniseWorthen reviewed Jun 12, 2023
View reviewed changes
tests/logs/RegressionTests_hera.log Outdated
Comment on lines 7577 to 7581
FAILED TESTS:
051 merra2_thompson_intel failed in check_result
merra2_thompson_intel 051 failed in run_test
172 atmaero_control_p8_rad_micro_intel failed in check_result
atmaero_control_p8_rad_micro_intel 172 failed in run_test
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnningCheng-NOAA Is the failure to the additional test expected? You listed only the merra2_thompson test in the expected test changes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnningCheng-NOAA can you resolve this conversation? @grantfirl can you make comment about this conversation?

@DeniseWorthen
Copy link
Collaborator

@AnningCheng-NOAA Please add any FV3 and/or CCPP PRs and issues which this PR depends on.

@AnningCheng-NOAA
Copy link
Contributor Author

AnningCheng-NOAA commented Jun 12, 2023 via email

@DeniseWorthen
Copy link
Collaborator

Denise: Yes. It is expected. atmaero_control_p8_rad_micro has set mraerosol=.true. and the baseline should chang accordingly.
…
On Mon, Jun 12, 2023 at 8:55 AM Denise Worthen @.> wrote: @.* commented on this pull request. ------------------------------ In tests/logs/RegressionTests_hera.log <#1788 (comment)> : > +FAILED TESTS: +051 merra2_thompson_intel failed in check_result +merra2_thompson_intel 051 failed in run_test +172 atmaero_control_p8_rad_micro_intel failed in check_result +atmaero_control_p8_rad_micro_intel 172 failed in run_test @AnningCheng-NOAA https://github.com/AnningCheng-NOAA Is the failure to the additional test expected? You listed only the merra2_thompson test in the expected test changes. — Reply to this email directly, view it on GitHub <#1788 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALQPMIMUYP4Y5QOD3PIVUUDXK4GTFANCNFSM6AAAAAAY3MJAIE . You are receiving this because you were mentioned.Message ID: @.***>

Great. Please update the PR to list this test also to the expected test changes

@AnningCheng-NOAA
Copy link
Contributor Author

A full set of regression tests have been completed in hera. The baseline of merra2_thompson and atmaero_control_p8_rad_micro need to be modified accordingly because they set mraersol=.true.. The rest tests are passed.

Attached are the log files.
rt_051_merra2_thompson_intel.log
rt_172_atmaero_control_p8_rad_micro_intel.log
run_051_merra2_thompson_intel.log
run_172_atmaero_control_p8_rad_micro_intel.log

@AnningCheng-NOAA
Copy link
Contributor Author

This PR(#1788), NOAA-EMC/fv3atm#664, and ufs-community/ccpp-physics#79 addresses issue #1786

@DeniseWorthen
Copy link
Collaborator

@AnningCheng-NOAA Can you add the linked issues and PRs to the template, under the section "Linked PRs and Issues"? You can do this by using the 3 dots at the very top of your PR (after "contributor") to open the edit function. You can also add the name of the additional changed test.

The reason for putting them in the linked section is that then they appear on the right-hand side of the PR, which will show the merge status for each of the linked PRs as they get committed. Thanks.

@DusanJovic-NOAA DusanJovic-NOAA changed the title PR in UFS for issure #1786 (https://github.com/ufs-community/ufs-weather-model/issues/1786) Fixed the warm bias in stratosphere from MERRA2 coupled microphysics Jun 14, 2023
@jkbk2004
Copy link
Collaborator

@AnningCheng-NOAA can you sync up branch ? As the test log RegressionTests_hera.log is attached, it can be ignored when resolving conflicts.

@AnningCheng-NOAA
Copy link
Contributor Author

@jkbk2004 done and RTs are on at /scratch1/NCEPDEV/climate/Anning.Cheng/tmp/ufs-weather-model/tests. Please let me know if you have any questions.

@BrianCurtis-NOAA
Copy link
Collaborator

Sorry to put more work on you. Make sure you update the CMEPS repo as it is out of date with the current develop branch.

Once this is resolved, please re-run tests on Hera or Cheyenne and attach the log to the comments and/or the PR information at the top.

@DeniseWorthen
Copy link
Collaborator

@AnningCheng-NOAA Please look at your log file. Most jobs failed to compile.

@AnningCheng-NOAA
Copy link
Contributor Author

AnningCheng-NOAA commented Jun 28, 2023 via email

@jkbk2004
Copy link
Collaborator

Hi, Brian: A dummy question: what is CMESP and how to update?
…
On Wed, Jun 28, 2023 at 12:01 PM Brian Curtis @.> wrote: Sorry to put more work on you. Make sure you update the CMEPS repo as it is out of date with the current develop branch. Once this is resolved, please re-run tests on Hera or Cheyenne and attach the log to the comments and/or the PR information at the top. — Reply to this email directly, view it on GitHub <#1788 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALQPMIML6BRQ2DEQUTYNB3TXNRIONANCNFSM6AAAAAAY3MJAIE . You are receiving this because you were mentioned.Message ID: @.>

@AnningCheng-NOAA This pr has nothing to do with cmeps component. So you need to point to correct cmeps hash in your branch. Correct one is NOAA-EMC/CMEPS@cec8db8

@AnningCheng-NOAA
Copy link
Contributor Author

@jkbk2004 could you give some instructions on how to point to NOAA-EMC/CMEPS@cec8db8?

@AnningCheng-NOAA
Copy link
Contributor Author

/scratch1/NCEPDEV/climate/Anning.Cheng/tmp/ufs-weather-model/CMEPS-interface/CMEPS% git checkout cec8db8

@AnningCheng-NOAA
Copy link
Contributor Author

Denise:

the compilation error is related to network. /scratch1/NCEPDEV/stmp2/Anning.Cheng/FV3_RT/rt_33495/compile_001/build_fv3_001/FV3/ccpp/ccpp_prebuild.err

I do not know if it has something to do with EMEPS. Could you take a quick look? Something is messed up, but nothing to do with my modifications.

@DeniseWorthen
Copy link
Collaborator

@AnningCheng-NOAA We need to see that the Regression tests all run and only the ones expected to fail actually do fail. I'm not sure why you're saying it is a system issue and not related to your changes.

To update the CMEPS component, you need to check out the correct hash and then commit the new hash.

@jkbk2004
Copy link
Collaborator

@AnningCheng-NOAA I recommend to sync from fv3 component level again since #1793 was merged. General sync steps are below but apply the sync procedure from FV3 side and then ufs-weather-model repository level.
Clone your fork and checkout feature/branch:
git clone https://github.com/JoeSmith-NOAA/ufs-weather-model.git
cd ufs-weather-model
git checkout feature/branch
Add upstream to set information of the authoritative repository from which the fork was created and fetch the upstream information into clone:
git remote add upstream https://github.com/ufs-community/ufs-weather-model.git
git fetch upstream
Merge upstream develop branch into feature/branch:
git merge upstream/develop
Resolve conflicts and Push the merged copy to fork feature/branch (origin):
git push origin feature/branch

@jkbk2004
Copy link
Collaborator

@AnningCheng-NOAA Also, regrading test failures, I see only two cases affected: merra2_thompson_intel and atmaero_control_p8_rad_micro_intel. Once you confirm that's the case, another round of regression test on hera can be done to fully validate after you sync the branches. Let me know if you need any help.

@jkbk2004
Copy link
Collaborator

@AnningCheng-NOAA Do you want me to directly sync up your branch?

@jkbk2004
Copy link
Collaborator

@AnningCheng-NOAA I synced up branch ok.

@jkbk2004
Copy link
Collaborator

@AnningCheng-NOAA I see "An error occured while running ccpp_prebuild.py, check" Can you check how it build on your side?

@AnningCheng-NOAA
Copy link
Contributor Author

AnningCheng-NOAA commented Jun 29, 2023 via email

@AnningCheng-NOAA AnningCheng-NOAA deleted the maie branch June 29, 2023 02:48
@AnningCheng-NOAA
Copy link
Contributor Author

Jong: There is a module load err (GNU) for experiments 38-51 at /scratch1/NCEPDEV/global/Anning.Cheng/tmp1/ufs-weather-model/tests when invoking compile.sh. Could you take a look?

@AnningCheng-NOAA
Copy link
Contributor Author

Never mind, I have fixed the problem and the RTs are running now, will upload the log files when done.

@jkbk2004
Copy link
Collaborator

@AnningCheng-NOAA Note that the pr is closed status. Once you commit any change to your fork branch with closed status, Git wouldn't allow to reopen with same PR number.

@AnningCheng-NOAA
Copy link
Contributor Author

@jkbk2004 why it is closed? how to reopen it?

@jkbk2004
Copy link
Collaborator

@AnningCheng-NOAA reopen button is not activated on my side. Can you try to reopen?

@jkbk2004
Copy link
Collaborator

@AnningCheng-NOAA agrees to re-open the pr.

@jkbk2004
Copy link
Collaborator

@AnningCheng-NOAA agrees to re-open the pr.

I am still not able to re-open on my side.

@AnningCheng-NOAA
Copy link
Contributor Author

Please reopen it. I will upload the new log files when all RTs are done. I had to start my branch from scratch yesterday. The changes on my side is much easier than debugging whatever was messed up when merging.

@AnningCheng-NOAA
Copy link
Contributor Author

I had deleted my branch maie yesterday. Did it trigger the close-up of the PR?

@AnningCheng-NOAA
Copy link
Contributor Author

@jkbk2004 the reopen button is not on my side either.

@AnningCheng-NOAA
Copy link
Contributor Author

Not sure why the PR was closed. Reopen it again.

@AnningCheng-NOAA
Copy link
Contributor Author

Do I need to create a new PR to replace this one to address issue #1786

@jkbk2004
Copy link
Collaborator

@AnningCheng-NOAA can you try to recover the pr? If the pr is not recovered with the following steps, then creating new pr is the way to go, I think.
git clone https://github.com/AnningCheng-NOAA/ufs-weather-model
cd ufs-weather-model
git checkout -b maie bfca985
git push --set-upstream origin maie

@AnningCheng-NOAA
Copy link
Contributor Author

The PR is still showing closed. I will create a new PR to replace this one.
reactive_PR1788

@AnningCheng-NOAA
Copy link
Contributor Author

Although I reopen a new PR1815 (#1815) to replace this one, I welcome any suggestions/ways to reopen this PR.

@grantfirl
Copy link
Collaborator

grantfirl commented Jun 30, 2023 •
edited
Loading

@AnningCheng-NOAA I can recreate all of the PRs for you if you make sure that the branches that you want to merge have all of the changes you want. Let me know if you want me to do this.

@AnningCheng-NOAA
Copy link
Contributor Author

AnningCheng-NOAA commented Jun 30, 2023 via email

@DeniseWorthen DeniseWorthen mentioned this pull request Jun 30, 2023
Merged
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkbk2004 jkbk2004 jkbk2004 left review comments

@DeniseWorthen DeniseWorthen DeniseWorthen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fixed the warm bias in stratosphere from MERRA2 coupled microphysics
5 participants
@AnningCheng-NOAA @grantfirl @DeniseWorthen @jkbk2004 @BrianCurtis-NOAA