Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unused ccpp suites to 'suites_not_used' directory #1793

Merged

Conversation

DusanJovic-NOAA
Copy link
Collaborator

@DusanJovic-NOAA DusanJovic-NOAA commented Jun 14, 2023

Description

This PR moves all unused ccpp suite definition files to a separate directory (suites_not_used). In FV3/ccpp/suites we currently have 101 suite definition files. Only 27 are actually used (tested).

Input data additions/changes

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Library Updates/Changes

  • Not Needed
  • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
  • Add issue link from JCSDA/spack-stack following this item

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved in section below
  • Confirm reviews completed in ALL sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne AND attach log to a PR comment.
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Depends on NOAA-EMC/fv3atm/pull/665
Closes NOAA-EMC/fv3atm/issues/510

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@DusanJovic-NOAA
Copy link
Collaborator Author

Regression test log files:
RegressionTests_hera.log
RegressionTests_orion.log

@jkbk2004
Copy link
Collaborator

@DusanJovic-NOAA We can work on this pr. can you sync up branch?

@DusanJovic-NOAA
Copy link
Collaborator Author

@DusanJovic-NOAA We can work on this pr. can you sync up branch?

Done

@jkbk2004 jkbk2004 added No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. jenkins-ci Jenkins CI: ORT build/test on docker container labels Jun 27, 2023
@FernandoAndrade-NOAA
Copy link
Collaborator

It looks like control_p8 dbg has failed in jenkins ci, verifying on Hera with a manual run

@FernandoAndrade-NOAA
Copy link
Collaborator

FernandoAndrade-NOAA commented Jun 27, 2023

@jkbk2004 Looks like the failure is due to a timeout in the control_p8_intel with dbg, other cases pass

@FernandoAndrade-NOAA FernandoAndrade-NOAA added hera-RT Run Hera regression testing cheyenne-RT jet-RT Run AutoRT Jet regression testing labels Jun 27, 2023
@FernandoAndrade-NOAA
Copy link
Collaborator

@epic-cicd-jenkins epic-cicd-jenkins removed cheyenne-RT jet-RT Run AutoRT Jet regression testing labels Jun 27, 2023
@BrianCurtis-NOAA
Copy link
Collaborator

@jkbk2004 Looks like the failure is due to a timeout in the control_p8_intel with dbg, other cases pass

Fixes are in #1810

on-behalf-of @ufs-community <ecc.platform@noaa.gov>
@FernandoAndrade-NOAA
Copy link
Collaborator

@jkbk2004 Looks like the failure is due to a timeout in the control_p8_intel with dbg, other cases pass

Fixes are in #1810

Awesome, thanks for the note. The test passed after increasing the wallclock limit in the default_vars.sh, looks like that PR fixes the issue altogether.

@FernandoAndrade-NOAA
Copy link
Collaborator

FernandoAndrade-NOAA commented Jun 28, 2023

Ok, testing is complete. I'll go ahead and leave a notice on the FV3 sub PR to get started with the merge process

@jkbk2004
Copy link
Collaborator

All tests are done. We can start merging process.

@jkbk2004
Copy link
Collaborator

@DusanJovic-NOAA fv3 pr was merged. We can merge here with hash update.

@DusanJovic-NOAA
Copy link
Collaborator Author

@DusanJovic-NOAA fv3 pr was merged. We can merge here with hash update.

Ready for merge.

@FernandoAndrade-NOAA FernandoAndrade-NOAA merged commit 18c44f1 into ufs-community:develop Jun 28, 2023
@DusanJovic-NOAA DusanJovic-NOAA deleted the unused_ccpp_suites branch June 28, 2023 18:11
@DeniseWorthen DeniseWorthen removed the hera-RT Run Hera regression testing label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jenkins-ci Jenkins CI: ORT build/test on docker container No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move deprecated suite definition files (SDFs) into a 'untested' subdirectory
7 participants