Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed stratosphere warm bias and code optimization for MERRA2 #664

Closed
wants to merge 5 commits into from

Conversation

AnningCheng-NOAA
Copy link
Contributor

@AnningCheng-NOAA AnningCheng-NOAA commented Jun 5, 2023

Description

(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
fixed stratosphere warm bias for merra2_thompson test
Is a change of answers expected from this PR?
yes

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

Testing

How were these changes tested?
regression test in hera
What compilers / HPCs was it tested with?
intel in hera
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
yes
Have the ufs-weather-model regression test been run? On what platform?

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

  • waiting on noaa-emc/nems/pull/<pr_number>
  • waiting on noaa-emc/fv3atm/pull/<pr_number>

@grantfirl
Copy link
Collaborator

@AnningCheng-NOAA You will need to "point" this fv3atm branch to your ccpp-physics PR branch:

  • On the machine where you developed this code, make sure that your ccpp-physics branch associated with this PR is checked out.

  • cd up to FV3

  • git add ccpp/physics -- this points the FV3 submodule to the correct commit of your ccpp-physics PR branch

  • edit .gitmodules to point to your PR branch of ccpp-physics
    instead of [submodule "ccpp/physics"]
    path = ccpp/physics
    url = https://github.com/ufs-community/ccpp-physics
    branch = ufs/dev
    you should have
    [submodule "ccpp/physics"]
    path = ccpp/physics
    url = https://github.com/AnningCheng-NOAA/ccpp-physics
    branch = maie

  • After editing .gitmodules, do git add .gitmodules

  • git commit

  • git push

@DusanJovic-NOAA DusanJovic-NOAA changed the title fixed stratosphere warm bias and code optimization for MERRA2 (https://github.com/ufs-community/ufs-weather-model/issues/1786) Fixed stratosphere warm bias and code optimization for MERRA2 Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fixed the warm bias in stratosphere from MERRA2 coupled microphysics
4 participants