Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/incommon updates #703

Merged
merged 13 commits into from
Oct 15, 2019
Merged

Feat/incommon updates #703

merged 13 commits into from
Oct 15, 2019

Conversation

paulineribeyre
Copy link
Contributor

@paulineribeyre paulineribeyre commented Oct 8, 2019

The first commit copies the changes from release 2.7.2 to master (InCommon updates)
Other commits:

  • Shibboleth documentation
  • add idp and shib_idp query parameters to /login/fence endpoint. Previously they were only in /authorize endpoint
  • Deprecate the ENABLED_IDENTITY_PROVIDERS config and replace by LOGIN_OPTIONS to allow enabling several login options for the same provider

TODO:

  • update docs

New Features

  • Support InCommon login: add "idp" and "shib_idp" query parameters to "/login/shib", "/login/fence" and "/authorize"

Deployment changes

  • Fence config ENABLED_IDENTITY_PROVIDERS section deprecated and replaced by LOGIN_OPTIONS section to allow enabling several login options for the same provider (backwards compatible)

@github-actions
Copy link

github-actions bot commented Oct 8, 2019

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls
Copy link

coveralls commented Oct 8, 2019

Pull Request Test Coverage Report for Build 7901

  • 63 of 106 (59.43%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 69.307%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fence/init.py 2 3 66.67%
fence/auth.py 2 3 66.67%
fence/blueprints/login/fence_login.py 3 6 50.0%
fence/blueprints/oauth2.py 0 4 0.0%
fence/blueprints/login/shib.py 6 22 27.27%
fence/blueprints/login/init.py 50 68 73.53%
Totals Coverage Status
Change from base Build 7897: -0.07%
Covered Lines: 5040
Relevant Lines: 7272

💛 - Coveralls

Copy link
Contributor

@fantix fantix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

docs/shibboleth.md Outdated Show resolved Hide resolved
docs/shibboleth.md Outdated Show resolved Hide resolved
docs/shibboleth.md Outdated Show resolved Hide resolved
docs/shibboleth.md Outdated Show resolved Hide resolved
fence/blueprints/login/__init__.py Outdated Show resolved Hide resolved
Copy link
Contributor

@fantix fantix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@paulineribeyre
Copy link
Contributor Author

paulineribeyre commented Oct 15, 2019

merging with 1 failed check - we know that the only failed jenkins test, ExportToWorkspaceTest: Export default manifest, mount it and check manifest name, has been flaky recently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants