Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shib): port shib changes from 2.7 branch #680

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(shib): port shib changes from 2.7 branch #680

wants to merge 2 commits into from

Conversation

Avantol13
Copy link
Contributor

@Avantol13 Avantol13 commented Aug 20, 2019 •
edited
Loading

New Features

  • support choosing a shibboleth IDP using query param

Breaking Changes

Bug Fixes

Improvements

Dependency updates

  • update shib dockerfile to python3

Deployment changes

@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls
Copy link

coveralls commented Aug 20, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 7667

  • 6 of 23 (26.09%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%
Changes Missing Coverage Covered Lines Changed/Added Lines %
fence/blueprints/oauth2.py 0 2 0.0%
fence/blueprints/login/shib.py 6 21 28.57%
Totals Coverage Status
Change from base Build 7654: 0.0%
Covered Lines:
Relevant Lines: 0
💛 - Coveralls

@paulineribeyre
Copy link
Contributor

2.7.2 branch changes have been ported in #703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Avantol13 @coveralls @paulineribeyre