fix(INJI-39): skip request for PHY upgrade to PHY2 [ hotfix ] #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alka1703
reviewed
May 17, 2023
krishnakumar4a4
requested changes
May 17, 2023
android/src/main/java/io/mosip/tuvali/ble/central/impl/GattClient.kt
Outdated
Show resolved
Hide resolved
reason: - if a preferential PHY is not requested in a connection, the BLE 5.0 chips which have issues with 2M PHY can also connect using older PHY and the responsibility of choosing a PHY is left to the firmware/OS and other entities concerns on speed: mosip#52 Link: https://mosip.atlassian.net/browse/INJI-39 Co-authored-by: Alka Prasad <prasadalka1998@gmail.com>
vijay151096
pushed a commit
that referenced
this pull request
May 30, 2023
Remove example folder and its related scripts to ensure that make build work on windows machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reason:
concerns on speed: mosip#52
Link: https://mosip.atlassian.net/browse/INJI-39
related PR: tw-mosip/inji-wallet#48