Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android - PHY value is not being set for specific devices #52

Open
adityankannan-tw opened this issue Mar 29, 2023 · 1 comment
Open

Android - PHY value is not being set for specific devices #52

adityankannan-tw opened this issue Mar 29, 2023 · 1 comment
Assignees
@krishnakumar4a4
Labels
bug Something isn't working

Comments

@adityankannan-tw
Copy link
Contributor

adityankannan-tw commented Mar 29, 2023 •
edited
Loading

While analysing the issue mosip/inji-wallet#523, we have observed that the PHY value is not being set somehow and that's the reason devices are getting stuck and not connecting for sharing.

Device Combination we have used to test the behaviour with and without setting the PHY :

  • Samsung Tab S6 Lite -- Verifier.
    Android version : 12
    BLE version : 5.0

  • Xiaomi Mi 11X -- Wallet.
    Android version : 13
    BLE version : 5.1

VC sizes used :

  • Small VC size - 20kb
  • Large VC size - 556kb

Here with i am attaching the observations in difference in transfer speeds with and without PHY between the above two device combinations and also the average time taken for your reference.

Screenshot 2023-03-29 at 4 20 49 PM

From the above image we can see,

  • Smaller VC transfer is faster without PHY.
  • But for Larger VC transfer is a bit slower without PHY.

-- FYI --
@adityankannan-tw adityankannan-tw added the bug Something isn't working label Mar 29, 2023
@adityankannan-tw adityankannan-tw changed the title Custom PHY analysis for BLE Android - PHY value is not being set for specific devices Mar 29, 2023
@krishnakumar4a4 krishnakumar4a4 self-assigned this Mar 29, 2023
@krishnakumar4a4 krishnakumar4a4 transferred this issue from mosip/inji-wallet Mar 29, 2023
krishnakumar4a4 pushed a commit that referenced this issue Apr 19, 2023
@Alka1703
Merge pull request #52 from tw-mosip/add-exception-handling-to-androi…
c6a2231 
…d-missing-files-hotfix

feat(#702): catch throwable instead of Exception
@tilak-puli tilak-puli mentioned this issue Apr 20, 2023
Closed
@Pragya279
Copy link

This bug has been moved to Jira.
Link to Jira bug: https://mosip.atlassian.net/browse/INJI-66

vharsh added a commit to tw-mosip/tuvali_old that referenced this issue May 4, 2023
@vharsh
fix(INJI-39): skip request for PHY upgrade to PHY2
ef94668 
reason:

- if a preferential PHY is not requested in a connection, the BLE 5.0
  chips which have issues with LE2MPHY can also connect using other
  PHY and the responsibility of choosing a PHY is left to the
  firmware/OS and other entities

concerns on speed: mosip#52

Link: https://mosip.atlassian.net/browse/INJI-39
vharsh added a commit to tw-mosip/tuvali_old that referenced this issue May 4, 2023
@vharsh
fix(INJI-39): skip request for PHY upgrade to PHY2
733340a 
reason:

- if a preferential PHY is not requested in a connection, the BLE 5.0
  chips which have issues with 2M PHY can also connect using older
  PHY and the responsibility of choosing a PHY is left to the
  firmware/OS and other entities

concerns on speed: mosip#52

Link: https://mosip.atlassian.net/browse/INJI-39
@vharsh vharsh mentioned this issue May 4, 2023
Merged
vharsh added a commit to tw-mosip/tuvali_old that referenced this issue May 4, 2023
@vharsh
fix(INJI-39): skip request for PHY upgrade to PHY2
927a0da 
reason:

- if a preferential PHY is not requested in a connection, the BLE 5.0
  chips which have issues with 2M PHY can also connect using older
  PHY and the responsibility of choosing a PHY is left to the
  firmware/OS and other entities

concerns on speed: mosip#52

Link: https://mosip.atlassian.net/browse/INJI-39
@vharsh vharsh mentioned this issue May 4, 2023
Merged
vharsh added a commit to tw-mosip/tuvali_old that referenced this issue May 4, 2023
@vharsh @Alka1703
fix(INJI-39): skip request for PHY upgrade to PHY2
dea5b35 
reason:

- if a preferential PHY is not requested in a connection, the BLE 5.0
  chips which have issues with 2M PHY can also connect using older
  PHY and the responsibility of choosing a PHY is left to the
  firmware/OS and other entities

concerns on speed: mosip#52

Link: https://mosip.atlassian.net/browse/INJI-39

Co-authored-by: Alka Prasad <prasadalka1998@gmail.com>
vharsh added a commit to tw-mosip/tuvali_old that referenced this issue May 4, 2023
@vharsh @Alka1703
fix(INJI-39): skip request for PHY upgrade to PHY2
4902ed7 
reason:

- if a preferential PHY is not requested in a connection, the BLE 5.0
  chips which have issues with 2M PHY can also connect using older
  PHY and the responsibility of choosing a PHY is left to the
  firmware/OS and other entities

concerns on speed: mosip#52

Link: https://mosip.atlassian.net/browse/INJI-39

Co-authored-by: Alka Prasad <prasadalka1998@gmail.com>
vharsh added a commit to tw-mosip/tuvali_old that referenced this issue May 4, 2023
@vharsh @Alka1703
fix(INJI-39): skip request for PHY upgrade to PHY2
4eb32ed 
reason:

- if a preferential PHY is not requested in a connection, the BLE 5.0
  chips which have issues with 2M PHY can also connect using older
  PHY and the responsibility of choosing a PHY is left to the
  firmware/OS and other entities

concerns on speed: mosip#52

Link: https://mosip.atlassian.net/browse/INJI-39

Co-authored-by: Alka Prasad <prasadalka1998@gmail.com>
vharsh added a commit to tw-mosip/tuvali_old that referenced this issue May 12, 2023
@vharsh @Alka1703
fix(INJI-39): skip request for PHY upgrade to PHY2
3a2dc80 
reason:

- if a preferential PHY is not requested in a connection, the BLE 5.0
  chips which have issues with 2M PHY can also connect using older
  PHY and the responsibility of choosing a PHY is left to the
  firmware/OS and other entities

concerns on speed: mosip#52

Link: https://mosip.atlassian.net/browse/INJI-39

Co-authored-by: Alka Prasad <prasadalka1998@gmail.com>
vharsh added a commit to tw-mosip/tuvali_old that referenced this issue May 17, 2023
@vharsh @Alka1703
fix(INJI-39): skip request for PHY upgrade to PHY2
e29f09e 
reason:

- if a preferential PHY is not requested in a connection, the BLE 5.0
  chips which have issues with 2M PHY can also connect using older
  PHY and the responsibility of choosing a PHY is left to the
  firmware/OS and other entities

concerns on speed: mosip#52

Link: https://mosip.atlassian.net/browse/INJI-39

Co-authored-by: Alka Prasad <prasadalka1998@gmail.com>
krishnakumar4a4 pushed a commit that referenced this issue May 19, 2023
@tilak-puli
feat(#52): use Exception as cause instead of Throwable and use Java L…
81eb874 
…og for logging exception
krishnakumar4a4 added a commit that referenced this issue May 19, 2023
@krishnakumar4a4
Merge pull request #55 from tw-mosip/fix-exception-handling-hotfix
66665fc 
feat(#52): use Exception as cause instead of Throwable
vharsh pushed a commit that referenced this issue May 30, 2023
@tilak-puli
feat(#52): pass exception as it is to exception handler instead of wr…
e30b2f1 
…apping it with unknown
vharsh pushed a commit that referenced this issue May 30, 2023
@tilak-puli
feat(#52): fix Exception import issues from merge
4e37ccf
vharsh pushed a commit that referenced this issue May 30, 2023
@tilak-puli
feat(#52): pass root cause Error code instead of parent exception
0163625
vharsh pushed a commit that referenced this issue May 30, 2023
@tilak-puli
feat(#52): add documentation for error codes
a1e1dc8
vharsh pushed a commit that referenced this issue May 30, 2023
@tilak-puli
feat(#52): use Exception as cause instead of Throwable and use Java L…
ef17839 
…og for logging exception
vharsh pushed a commit that referenced this issue May 30, 2023
@tilak-puli
feat(#52): move statehandler exceptions to respective module
4be7caa
vharsh pushed a commit that referenced this issue May 30, 2023
@tilak-puli
feat(#52): separate exception handling to a new vertical
b017b09
vharsh pushed a commit that referenced this issue May 30, 2023
@krishnakumar4a4
feat(#52): re-organise exceptions to individual packages
bced3a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krishnakumar4a4 krishnakumar4a4

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@krishnakumar4a4 @Pragya279 @adityankannan-tw