fix(INJI-39): add new Bluetooth permission for Android12 [ hotfix ] #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason for adding BLUETOOTH_{SCAN,CONNECT,ADVERTISE}
- enables Android12(API level31 & above) devices to scan for BLE
peripherals
ref: https://developer.android.com/guide/topics/connectivity/bluetooth/permissions#declare-android12-or-higher
without this changeset, an exception is thrown
- this permission was added in API level 31, hence bumped up
compileSdkVersion
Co-authored-by: Alka Prasad <prasadalka1998@gmail.com>
krishnakumar4a4
requested changes
May 17, 2023
|
I've pushed the changes @krishnakumar4a4, I'll test this on Android 10 & available Android 13 and revert back. |
|
@krishnakumar4a4 I've tested the changes, please review it. |
krishnakumar4a4
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for adding BLUETOOTH_{SCAN,CONNECT,ADVERTISE}