Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: bump mission deps #15197

Merged
merged 9 commits into from
Nov 6, 2024
Merged

Chore: bump mission deps #15197

merged 9 commits into from
Nov 6, 2024

Conversation

Lemonexe
Copy link
Contributor

@Lemonexe Lemonexe commented Nov 4, 2024

Description

Update most Mission-related dependencies:
major:

  • electron
    • updated webpack compilation target to Chromium 130
      • it wasn't supported by our browserlist, so I bumped webpack also
  • uuid
    • rewritten to TS, so we are dropping @types/uuid, see ℹ️ note in README
  • openpgp

minor:

  • electron-builder
  • webpack

patch:

  • electron-updater
  • react-hook-form
  • @hookform/resolvers
  • express

not updated:

  • tiny-secp256k1 TODO in #12261
  • electron-store requires refactoring our electron main process to ES = out of scope but planned

ℹ️ For reference, last bump mission deps PR was #14684

QA

👁️ Besides CI checks, I have tested locally:

  • local suite web
  • local suite desktop
    • tested Tor because utilityProcess was touched
    • superifical testing of google auth server: responds to GET localhost:3005/status
    • app update
    • react-hook-form & @hookform/resolvers tested in SignVerify page
  • linux build

Copy link

socket-security bot commented Nov 4, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/app-builder-lib@25.1.8

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

Copy link

github-actions bot commented Nov 4, 2024

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 10
  • More info

Learn more about 𝝠 Expo Github Action

@Lemonexe
Copy link
Contributor Author

Lemonexe commented Nov 5, 2024

@SocketSecurity ignore npm/app-builder-lib@25.1.8

I took a look, and the code in question is a part of electron-builder responsible for parsing ES | CommonJS modules. Nothing new, has been there since 12.2023 🙂

@Lemonexe Lemonexe force-pushed the chore/bump-mission-deps branch from db6024a to 59edf23 Compare November 6, 2024 19:27
@Lemonexe Lemonexe marked this pull request as ready for review November 6, 2024 19:28
Copy link
Contributor

@peter-sanderson peter-sanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@Lemonexe Lemonexe merged commit a66ece5 into develop Nov 6, 2024
69 checks passed
@Lemonexe Lemonexe deleted the chore/bump-mission-deps branch November 6, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants