Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: bump foundation deps #15752

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Chore: bump foundation deps #15752

merged 3 commits into from
Dec 4, 2024

Conversation

Lemonexe
Copy link
Contributor

@Lemonexe Lemonexe commented Dec 3, 2024

Description

Update most Foundation-related dependencies:

major version: none

minor version:

  • eslint
  • @eslint/js
  • typescript-eslint
  • eslint-plugin-jest

patch version:

  • react-hook-form
  • uuid

not updated:

  • electron will be instead downgraded, because we want to keep support for macOS Catalina.
  • tiny-secp256k1 TODO in #12261
  • electron-store blocked by #14482
  • openpgp
    • I tried 6.0.1 but it has the same problem as 6.0.0 (we had to revert in #15305 cause it broke windows build)
    • if I have time I'll look into their source code but not RN

ℹ️ For reference, last bump foundation deps PR was #15197

QA

👁️ Besides CI checks, I have tested locally:

  • local suite web
  • local suite desktop
    • react-hook-form tested in SignVerify page

Copy link

github-actions bot commented Dec 3, 2024

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 17
  • More info

Learn more about 𝝠 Expo Github Action

@Lemonexe Lemonexe marked this pull request as ready for review December 3, 2024 16:50
@Lemonexe Lemonexe marked this pull request as draft December 4, 2024 10:28
@Lemonexe Lemonexe force-pushed the chore/bump-foundation-deps branch from c6904c3 to e5610e5 Compare December 4, 2024 10:35
@Lemonexe Lemonexe marked this pull request as ready for review December 4, 2024 10:49
@Lemonexe Lemonexe merged commit e8d4089 into develop Dec 4, 2024
69 checks passed
@Lemonexe Lemonexe deleted the chore/bump-foundation-deps branch December 4, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants