Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix: Updated R minimum version #255

Merged
merged 31 commits into from
Jan 28, 2025
Merged

Minor fix: Updated R minimum version #255

merged 31 commits into from
Jan 28, 2025

Conversation

fontikar
Copy link
Collaborator

Towards #250

Addressing:

 Missing dependency on R >= 4.1.0 because package code uses the pipe
  |> or function shorthand \(...) syntax added in R 4.1.0.
  File(s) using such syntax:
    'load_taxonomic_resources.R' 'release.R' 'state_diversity_counts.R'
* checking top-level files ... OK

Note on Incoming feasibility can be safely ignored

dfalster and others added 30 commits May 6, 2024 17:22
* spelling fixes and removing special Mac install instructions

* adding mac back into CI
* Added example for default_version, updated LICENSE year, added R CMD CHECK results

* Comment about Tidy and Mac and HTML validation

* Updated CITATION file

* Updated version numbers
* Added example for default_version, updated LICENSE year, added R CMD CHECK results

* Comment about Tidy and Mac and HTML validation

* Updated CITATION file

* Updated version numbers

* Removed auto package version in citation

* Updated CRAN comments

* Fixed typo in CITATION

* Resubmitted

---------

Co-authored-by: Fonti Kar <f.kar@unsw.edu.au>
merging master back into develop to correct mistake
* fix example

* fix vignette paths
* dealing with cran and CI issues (#236)

* Bump version number (1.0.0.9000)

[skip ci]

* spelling fixes and removing special Mac install instructions (#229)

* spelling fixes and removing special Mac install instructions

* adding mac back into CI

* Cran preparations (#230)

* Added example for default_version, updated LICENSE year, added R CMD CHECK results

* Comment about Tidy and Mac and HTML validation

* Updated CITATION file

* Updated version numbers

* cleaning up (#231)

* Added example for default_version, updated LICENSE year, added R CMD CHECK results

* Comment about Tidy and Mac and HTML validation

* Updated CITATION file

* Updated version numbers

* Removed auto package version in citation

* Updated CRAN comments

* Fixed typo in CITATION

* Resubmitted

---------

Co-authored-by: Fonti Kar <f.kar@unsw.edu.au>

* fixing badges

* Tweaks (#234)

* fix example

* fix vignette paths

* testing for issue #235

* still working on #235

* one more try to find the edge case

* another edge case?

* reformat code in release file

* another edge case

* reverting previous commit to documentation

* adding check on resources to all functions that need resources

* bumping version number and updating readme

* missed two checking spots

---------

Co-authored-by: Daniel Falster <daniel.falster@unsw.edu.au>
Co-authored-by: Fonti Kar <f.kar@unsw.edu.au>
Co-authored-by: Dave Slager <slager@users.noreply.github.com>

* Update new

* fixing bug in hidden function and re-naming a bit

* adding new genus in family function

* testing?

* namespaces

* testing testing

* forgot how namespaces work

* so many details *sigh*

---------

Co-authored-by: Daniel Falster <daniel.falster@unsw.edu.au>
Co-authored-by: Fonti Kar <f.kar@unsw.edu.au>
Co-authored-by: Dave Slager <slager@users.noreply.github.com>
Merge branch 'master' into develop

# Conflicts:
#	NEWS.md
Merge branch 'master' into develop
Copy link
Contributor

@wcornwell wcornwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@fontikar fontikar merged commit 59ae1ee into master Jan 28, 2025
11 checks passed
wcornwell added a commit that referenced this pull request Feb 3, 2025
* Adjust CPU for tests (#254)

* Minor fix: Updated R minimum version  (#255)

* Removing test that conflicts with the edge case handling approach previously implemented

---------

Co-authored-by: Fonti Kar <f.kar@unsw.edu.au>
dfalster pushed a commit that referenced this pull request Feb 4, 2025
* Adjust CPU for tests (#254)

* Minor fix: Updated R minimum version  (#255)

* Removing test that conflicts with the edge case handling approach previously implemented

---------

Co-authored-by: Fonti Kar <f.kar@unsw.edu.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants