Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dealing with cran and CI issues #236

Merged
merged 17 commits into from
Jul 31, 2024
Merged

dealing with cran and CI issues #236

merged 17 commits into from
Jul 31, 2024

Conversation

wcornwell
Copy link
Contributor

Dealing with the vignette issues that emerged here:
https://cran.r-project.org/web/checks/check_results_APCalign.html
and some other "graceful failing" issues that have come up on github CI recently.

dfalster and others added 17 commits May 6, 2024 17:22
* spelling fixes and removing special Mac install instructions

* adding mac back into CI
* Added example for default_version, updated LICENSE year, added R CMD CHECK results

* Comment about Tidy and Mac and HTML validation

* Updated CITATION file

* Updated version numbers
* Added example for default_version, updated LICENSE year, added R CMD CHECK results

* Comment about Tidy and Mac and HTML validation

* Updated CITATION file

* Updated version numbers

* Removed auto package version in citation

* Updated CRAN comments

* Fixed typo in CITATION

* Resubmitted

---------

Co-authored-by: Fonti Kar <f.kar@unsw.edu.au>
merging master back into develop to correct mistake
* fix example

* fix vignette paths
Copy link
Member

@dfalster dfalster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @wcornwell !!

@wcornwell wcornwell merged commit dfcafde into master Jul 31, 2024
11 checks passed
wcornwell added a commit that referenced this pull request Aug 13, 2024
* dealing with cran and CI issues (#236)

* Bump version number (1.0.0.9000)

[skip ci]

* spelling fixes and removing special Mac install instructions (#229)

* spelling fixes and removing special Mac install instructions

* adding mac back into CI

* Cran preparations (#230)

* Added example for default_version, updated LICENSE year, added R CMD CHECK results

* Comment about Tidy and Mac and HTML validation

* Updated CITATION file

* Updated version numbers

* cleaning up (#231)

* Added example for default_version, updated LICENSE year, added R CMD CHECK results

* Comment about Tidy and Mac and HTML validation

* Updated CITATION file

* Updated version numbers

* Removed auto package version in citation

* Updated CRAN comments

* Fixed typo in CITATION

* Resubmitted

---------

Co-authored-by: Fonti Kar <f.kar@unsw.edu.au>

* fixing badges

* Tweaks (#234)

* fix example

* fix vignette paths

* testing for issue #235

* still working on #235

* one more try to find the edge case

* another edge case?

* reformat code in release file

* another edge case

* reverting previous commit to documentation

* adding check on resources to all functions that need resources

* bumping version number and updating readme

* missed two checking spots

---------

Co-authored-by: Daniel Falster <daniel.falster@unsw.edu.au>
Co-authored-by: Fonti Kar <f.kar@unsw.edu.au>
Co-authored-by: Dave Slager <slager@users.noreply.github.com>

* Update new

* fixing bug in hidden function and re-naming a bit

* adding new genus in family function

* testing?

* namespaces

* testing testing

* forgot how namespaces work

* so many details *sigh*

---------

Co-authored-by: Daniel Falster <daniel.falster@unsw.edu.au>
Co-authored-by: Fonti Kar <f.kar@unsw.edu.au>
Co-authored-by: Dave Slager <slager@users.noreply.github.com>
wcornwell added a commit that referenced this pull request Aug 13, 2024
* Bump version number (1.0.0.9000)

[skip ci]

* spelling fixes and removing special Mac install instructions (#229)

* spelling fixes and removing special Mac install instructions

* adding mac back into CI

* Cran preparations (#230)

* Added example for default_version, updated LICENSE year, added R CMD CHECK results

* Comment about Tidy and Mac and HTML validation

* Updated CITATION file

* Updated version numbers

* cleaning up (#231)

* Added example for default_version, updated LICENSE year, added R CMD CHECK results

* Comment about Tidy and Mac and HTML validation

* Updated CITATION file

* Updated version numbers

* Removed auto package version in citation

* Updated CRAN comments

* Fixed typo in CITATION

* Resubmitted

---------

Co-authored-by: Fonti Kar <f.kar@unsw.edu.au>

* fixing badges

* Tweaks (#234)

* fix example

* fix vignette paths

* testing for issue #235

* still working on #235

* one more try to find the edge case

* another edge case?

* reformat code in release file

* another edge case

* reverting previous commit to documentation

* adding check on resources to all functions that need resources

* bumping version number and updating readme

* missed two checking spots

* 238 genus family lookup (#239)

* dealing with cran and CI issues (#236)

* Bump version number (1.0.0.9000)

[skip ci]

* spelling fixes and removing special Mac install instructions (#229)

* spelling fixes and removing special Mac install instructions

* adding mac back into CI

* Cran preparations (#230)

* Added example for default_version, updated LICENSE year, added R CMD CHECK results

* Comment about Tidy and Mac and HTML validation

* Updated CITATION file

* Updated version numbers

* cleaning up (#231)

* Added example for default_version, updated LICENSE year, added R CMD CHECK results

* Comment about Tidy and Mac and HTML validation

* Updated CITATION file

* Updated version numbers

* Removed auto package version in citation

* Updated CRAN comments

* Fixed typo in CITATION

* Resubmitted

---------

Co-authored-by: Fonti Kar <f.kar@unsw.edu.au>

* fixing badges

* Tweaks (#234)

* fix example

* fix vignette paths

* testing for issue #235

* still working on #235

* one more try to find the edge case

* another edge case?

* reformat code in release file

* another edge case

* reverting previous commit to documentation

* adding check on resources to all functions that need resources

* bumping version number and updating readme

* missed two checking spots

---------

Co-authored-by: Daniel Falster <daniel.falster@unsw.edu.au>
Co-authored-by: Fonti Kar <f.kar@unsw.edu.au>
Co-authored-by: Dave Slager <slager@users.noreply.github.com>

* Update new

* fixing bug in hidden function and re-naming a bit

* adding new genus in family function

* testing?

* namespaces

* testing testing

* forgot how namespaces work

* so many details *sigh*

---------

Co-authored-by: Daniel Falster <daniel.falster@unsw.edu.au>
Co-authored-by: Fonti Kar <f.kar@unsw.edu.au>
Co-authored-by: Dave Slager <slager@users.noreply.github.com>

* bumping version number and updating news

* update readme

* no empty lines in description

---------

Co-authored-by: Daniel Falster <daniel.falster@unsw.edu.au>
Co-authored-by: Fonti Kar <f.kar@unsw.edu.au>
Co-authored-by: Dave Slager <slager@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants