Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_system_msgs): change operation mode messages #46

Merged
merged 13 commits into from
Nov 10, 2022

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Aug 5, 2022

Signed-off-by: Takagi, Isamu isamu.takagi@tier4.jp

Related Links

autowarefoundation/autoware.universe#1535

Description

Change the messages for this PR.

Remarks

None

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Code is properly formatted
  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code is properly formatted
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
isamu-takagi and others added 7 commits September 20, 2022 14:37
@isamu-takagi
Copy link
Contributor Author

@TakaHoribe Please approve if this is okay.

@isamu-takagi isamu-takagi requested a review from tkhmy October 26, 2022 05:16
@tkhmy
Copy link
Contributor

tkhmy commented Oct 27, 2022

@isamu-takagi, Do it mean that checking the IsAutonomousAvailable will not be used anymore?
Currently, some of the tools is using it to check whether the vehicle can engage.

@isamu-takagi
Copy link
Contributor Author

@tkhmy
Yes, IsAutonomousAvailable will be replaced with ModeChangeAvailable. Actually, the application uses is_***_mode_available in OperationModeState. This message is created by the operation mode API using ModeChangeAvailable.

Copy link
Contributor

@tkhmy tkhmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi merged commit 971f2ea into tier4/universe Nov 10, 2022
@isamu-takagi isamu-takagi deleted the feature/ad-api/operation-mode-manager branch November 10, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants