-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(default_ad_api): add operation mode api #1569
feat(default_ad_api): add operation mode api #1569
Conversation
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…d-api/operation-mode
…ate.msg Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
…ate.msg Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…d-api/operation-mode
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…d-api/operation-mode
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…d-api/operation-mode
…d-api/operation-mode
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Codecov ReportBase: 11.09% // Head: 11.14% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1569 +/- ##
==========================================
+ Coverage 11.09% 11.14% +0.04%
==========================================
Files 1213 1205 -8
Lines 86618 86380 -238
Branches 20787 20866 +79
==========================================
+ Hits 9612 9626 +14
+ Misses 66847 66571 -276
- Partials 10159 10183 +24
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi cc: @yabuta
|
@tkhmy Thank you for the comments.
|
|
QoS of this topic is reliable/transient_local, so the application can read the message even if it is started later.
The state needed to set the initial pose.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested the new api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat(autoware_ad_api_msgs): define operation mode interface Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(default_ad_api): add operation mode api Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: add message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Update common/autoware_ad_api_msgs/operation_mode/msg/OperationModeState.msg Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update common/autoware_ad_api_msgs/operation_mode/msg/OperationModeState.msg Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * fix: add message callback Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: add topic monitoring Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: use topic monitoring Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: modify topic monitoring config Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: config name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: modify diag name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move adapi message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: change message type Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: merge Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * WIP Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: fix build error Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move diagnostics Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: remove diagnostics Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: modify error message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: remove unused code Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
* feat(autoware_ad_api_msgs): define operation mode interface Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(default_ad_api): add operation mode api Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: add message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Update common/autoware_ad_api_msgs/operation_mode/msg/OperationModeState.msg Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update common/autoware_ad_api_msgs/operation_mode/msg/OperationModeState.msg Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * fix: add message callback Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: add topic monitoring Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: use topic monitoring Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: modify topic monitoring config Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: config name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: modify diag name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move adapi message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: change message type Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: merge Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * WIP Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: fix build error Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move diagnostics Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: remove diagnostics Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: modify error message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: remove unused code Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Signed-off-by: kminoda <koji.minoda@tier4.jp>
* feat(autoware_ad_api_msgs): define operation mode interface Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(default_ad_api): add operation mode api Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: add message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Update common/autoware_ad_api_msgs/operation_mode/msg/OperationModeState.msg Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update common/autoware_ad_api_msgs/operation_mode/msg/OperationModeState.msg Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * fix: add message callback Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: add topic monitoring Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: use topic monitoring Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: modify topic monitoring config Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: config name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: modify diag name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move adapi message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: change message type Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: merge Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * WIP Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: fix build error Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move diagnostics Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: remove diagnostics Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: modify error message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: remove unused code Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: Takagi, Isamu isamu.takagi@tier4.jp
Description
This is an implementation of operation mode API. For details, see the discussion page.
Related links
#1535
#1586
tier4/tier4_autoware_msgs#46
Tests performed
change_to_autonomous
service, and check if the vehicle starts.change_to_stop
service, and check if the vehicle stops.change_to_local
andchange_to_remote
services, and check if gate_mode and selector_mode are changed (AutowareStatePanel is useful).Notes for reviewers
Commands
ros2 service call /api/operation_mode/change_to_stop autoware_adapi_v1_msgs/srv/ChangeOperationMode
ros2 service call /api/operation_mode/change_to_autonomous autoware_adapi_v1_msgs/srv/ChangeOperationMode
ros2 service call /api/operation_mode/change_to_local autoware_adapi_v1_msgs/srv/ChangeOperationMode
ros2 service call /api/operation_mode/change_to_remote autoware_adapi_v1_msgs/srv/ChangeOperationMode
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.