-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(operation_mode_transition_manager): support ad api #1535
feat(operation_mode_transition_manager): support ad api #1535
Conversation
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
1fc9ecd
to
2076df8
Compare
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…d-api/operation-mode-transition-manager
…ate.msg Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
…ate.msg Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
…d-api/operation-mode-transition-manager
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
This pull request has been automatically marked as stale because it has not had recent activity. |
…d-api/operation-mode-transition-manager
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…thub.com:isamu-takagi/autoware.universe into feature/ad-api/operation-mode-transition-manager
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested with following case
- vehicle engage during manual driving
- change from engage to manual driving and back to engage
- when vehicle is out of the lane, it will not engage
CI will pass after merging tier4/tier4_autoware_msgs#46. |
Codecov ReportBase: 11.14% // Head: 11.09% // Decreases project coverage by
Additional details and impacted files
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…dation#1535) * feat(operation_mode_transition_manager): support ad api Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: merge operation mode state message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(autoware_ad_api_msgs): define operation mode interface Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: add message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Update common/autoware_ad_api_msgs/operation_mode/msg/OperationModeState.msg Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update common/autoware_ad_api_msgs/operation_mode/msg/OperationModeState.msg Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * feat: apply field name change Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move adapi message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: change message type Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: fix build error Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: fix error message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * WIP Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: add compatibility Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: fix operation mode change when disable autoware control Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: fix operation mode change when autoware control is disabled Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…dation#1535) * feat(operation_mode_transition_manager): support ad api Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: merge operation mode state message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(autoware_ad_api_msgs): define operation mode interface Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: add message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Update common/autoware_ad_api_msgs/operation_mode/msg/OperationModeState.msg Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update common/autoware_ad_api_msgs/operation_mode/msg/OperationModeState.msg Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * feat: apply field name change Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move adapi message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: change message type Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: fix build error Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: fix error message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * WIP Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: add compatibility Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: fix operation mode change when disable autoware control Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: fix operation mode change when autoware control is disabled Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
…k-point-types-update feat: cherry pick point types update
Signed-off-by: Takagi, Isamu isamu.takagi@tier4.jp
Description
The operation mode transition manager supports AD API. State transition is unified as follows (local mode is same as remote).
When in vehicle control mode (disengage), the operation mode can be changed immediately without checking. When the control mode changes to autoware (engage) or the operation mode changes in autoware control mode (e.g. stop to autonomous), the operation mode will be transition mode. The transition mode exits when the conditions are satisfied.
Related links
tier4/tier4_autoware_msgs#46
Tests performed
Notes for reviewers
By default, the transition time is too short for testing. It can be changed with this parameter.
launch/tier4_control_launch/config/operation_mode_transition_manager/operation_mode_transition_manager.param.yaml
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.