Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): disable rosbridge to fix duplicated node #497

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

kosuke55
Copy link

@kosuke55 kosuke55 commented Jul 19, 2024

Description

#496 によりmainとtier4_autoware_api_component.launchを合わせたが/rosbridge_websocketが二重に起動するようになりengaegでできなくなる問題は修正。

fix

header:
  stamp:
    sec: 1721364475
    nanosec: 340473583
  frame_id: ''
status:
- level: "\x02"
  name: 'duplicated_node_checker: duplicated_node_checker'
  message: 'Error: Duplicated nodes detected[/rosbridge_websocket], '
  hardware_id: duplicated_node_checker
  values:
  - key: Duplicated Node Name
    value: /rosbridge_websocket
---

変更後もfoaは動作することは確認

Tests performed

psim with foa

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Copy link

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kosuke55 kosuke55 merged commit 1b04604 into awf-latest Jul 19, 2024
14 checks passed
@kosuke55 kosuke55 deleted the fix/system branch July 19, 2024 05:00
tier4-autoware-public-bot bot added a commit that referenced this pull request Jul 30, 2024
…oundation#1085)

* feat: use obstacle_cruise_planner and change safe_distance_margin

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat: set max_vel to 40km/h

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat: enable surround_obstacle_checker

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat: enable surround_obstacle_checker

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat: enable dynamic_avoidance and disable outside_drivable_area_stop

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat: disable AEB and set the maximum velocity to 40km/h

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* enable intersection_occlusion detection

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* chore(planning_launch): update motion module name (autowarefoundation#1014)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* disable AEB diag check

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* feat(diagnostic_graph_utils): launch logging node for diagnostic_graph

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* feat(api): set launch_deprecated_api true (#496)

feat(api): launch_deprecated_api=true

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix(api): disable rosbridge to fix duplicated node (#497)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* feat(crosswalk): more conservative when the ego pass first

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com>
Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Co-authored-by: Mamoru Sobue <hilo.soblin@gmail.com>
Co-authored-by: badai nguyen <94814556+badai-nguyen@users.noreply.github.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Co-authored-by: danielsanchezaran <daniel.sanchez@tier4.jp>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
kosuke55 added a commit that referenced this pull request Aug 1, 2024
kosuke55 added a commit that referenced this pull request Aug 1, 2024
Revert "fix(api): disable rosbridge to fix duplicated node (#497)"

This reverts commit 1b04604.
kosuke55 added a commit that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants