feat(api): set launch_deprecated_api true #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
go-sakayori
approved these changes
Jul 18, 2024
4 tasks
tier4-autoware-public-bot bot
added a commit
that referenced
this pull request
Jul 30, 2024
…oundation#1085) * feat: use obstacle_cruise_planner and change safe_distance_margin Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat: set max_vel to 40km/h Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat: enable surround_obstacle_checker Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat: enable surround_obstacle_checker Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat: enable dynamic_avoidance and disable outside_drivable_area_stop Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat: disable AEB and set the maximum velocity to 40km/h Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * enable intersection_occlusion detection Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * chore(planning_launch): update motion module name (autowarefoundation#1014) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * disable AEB diag check Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * feat(diagnostic_graph_utils): launch logging node for diagnostic_graph Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * feat(api): set launch_deprecated_api true (#496) feat(api): launch_deprecated_api=true Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix(api): disable rosbridge to fix duplicated node (#497) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * feat(crosswalk): more conservative when the ego pass first Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Co-authored-by: Mamoru Sobue <hilo.soblin@gmail.com> Co-authored-by: badai nguyen <94814556+badai-nguyen@users.noreply.github.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: Daniel Sanchez <danielsanchezaran@gmail.com> Co-authored-by: danielsanchezaran <daniel.sanchez@tier4.jp> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://star4.slack.com/archives/C03QW0GU6P7/p1716891686276349?thread_ts=1715690581.066659&cid=C03QW0GU6P7 を参照。
https://github.com/tier4/autoware_launch/blob/tier4/main/autoware_launch/launch/components/tier4_autoware_api_component.launch.xml#L4 では launch_deprecated_api=trueにしているが、awf-latestではpsimではfalseになる。この場合FOAの起動が出来なくなるなどの不便が生じるため、tier4/mainに合わせてtrueにする。
ローカルでawf/mainのマージが出来てたので、awf/main -> tier4/awf-latestのsync (https://github.com/tier4/autoware_launch/blob/tier4/main/.github/workflows/sync-awf-latest.yaml) も動くはず？
(動かなかったらsync修正する必要あり)
Tests performed
2024/07/18 https://evaluation.tier4.jp/evaluation/reports/dcff9a18-1edc-593d-86e3-65808b3fe2ce/?project_id=prd_jt
psim
foaは一部無効にしないと動かないが別問題そう
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.