Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

feat(control_launch): add disable-emergency option in velocity_controller #377

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Jun 30, 2022

PR Type

  • New Feature

Related Links

See below.

Description

Add parameter for autowarefoundation/autoware.universe#1201

The default parameter enables emergency stop.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

…ller

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe force-pushed the feature/add-disable-emergency-option branch from 1036110 to 0da94ff Compare June 30, 2022 13:12
@TakaHoribe TakaHoribe changed the title Feature/add disable emergency option feat(control_launch): add disable-emergency option in velocity_controller Jun 30, 2022
@TakaHoribe TakaHoribe requested a review from tkimura4 June 30, 2022 13:12
Copy link
Collaborator

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit 4065264 into awf-latest Jul 5, 2022
@tkimura4 tkimura4 deleted the feature/add-disable-emergency-option branch July 5, 2022 03:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants