This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
feat: change input pointcloud from outside of launch file #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34edbac to
10e95b0
Compare
10e95b0 to
92b048c
Compare
YamatoAndo
reviewed
Apr 5, 2022
8 tasks
f62e610 to
675910c
Compare
675910c to
4efa1f9
Compare
|
Since it includes the issue of what to do with the container, I will separate PR and import the modified topic name only. |
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
|
@h-ohta |
h-ohta
reviewed
Apr 7, 2022
h-ohta
approved these changes
Apr 11, 2022
takayuki5168
pushed a commit
that referenced
this pull request
May 26, 2022
boyali
pushed a commit
to boyali/autoware_launch
that referenced
this pull request
Jul 26, 2022
…aunch file (tier4#257) (tier4#242) * feat: change input pointcloud from outside of launch file (tier4#257) * change localization util input topic * add arg to input arbitrary lidar topic to perception module * remove default value except autoware and logging launch * add default value in localization and perception launch * remove default value from root launch file * change input_sensor_points_topic to input/pointcloud * cosmetic change * feat: use pointcloud container * feat: move into util * ci(pre-commit): autofix * feat: make final output topic arg * fix: typo * fix: some lack things * fix: revert use pointcloud container * change to work tutorial Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * change to work tutorial Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: h-ohta <hiroki.ota@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix : to outlier_filtered/pointcloud Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix: add missing arg * fix : topic arg Signed-off-by: tanaka3 <ttatcoder@outlook.jp> Co-authored-by: Taichi Higashide <azumade.30@gmail.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: h-ohta <hiroki.ota@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
tier4/aip_launcher#24
Description
I've changed input topic of localization and perception module from rectified/pointcloud to outlier_filtered/pointcloud.
It was not possible to pass a topic name to lidar detection node from launcher as an argument so far, so I fixed that as well.
@h-ohta added
containeras argumentrearrange output topic arg<- sipin out to feat(localization_launch): change argument structure in util.launch #270Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks