Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

feat(localization_launch): change argument structure in util.launch #270

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Apr 7, 2022

PR Type

  • Improvement

Related Links

Spin out from tier4/autoware_launch#257

Description

  • rearrange arguments
  • remove output_measurement_range_sensor_points_topic and output_voxel_grid_downsample_sensor_points_topic since I've never seen to be changed them

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@h-ohta h-ohta requested a review from YamatoAndo April 7, 2022 02:06
@h-ohta h-ohta force-pushed the feat/localization_util branch from 003517e to 6a9ea0f Compare April 7, 2022 02:32
@h-ohta h-ohta merged commit 228d7ed into tier4/universe Apr 7, 2022
@h-ohta h-ohta deleted the feat/localization_util branch April 7, 2022 03:27
s-azumi pushed a commit to s-azumi/autoware_launch that referenced this pull request Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants