Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

fix: split vehicle model package into description and launch #213

Closed
wants to merge 2 commits into from
Closed

fix: split vehicle model package into description and launch #213

wants to merge 2 commits into from

Conversation

kenji-miyake
Copy link
Contributor

@kenji-miyake kenji-miyake commented Feb 19, 2022 •
edited
Loading

PR Type

  • Fix for API change

Related Links

tier4/lexus_description.iv#23

Description

Fix the package path for tier4/lexus_description.iv#23.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

fix: split vehivle model package into description and launch
aa26139 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@kenji-miyake kenji-miyake mentioned this pull request Feb 19, 2022
Closed
wep21
wep21 reviewed Feb 19, 2022
View reviewed changes
vehicle_launch/README.md Outdated Show resolved Hide resolved
@kenji-miyake @wep21
Update vehicle_launch/README.md
32f0e24 
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
@h-ohta h-ohta changed the title fix: split vehivle model package into description and launch fix: split vehicle model package into description and launch Feb 21, 2022
@yukkysaito
Copy link
Collaborator

LGTM

@h-ohta
Copy link
Contributor

h-ohta commented Mar 3, 2022

@kenji-miyake When dou you merge this pr?

@kenji-miyake
Copy link
Contributor Author

@h-ohta Any time is okay for me, I think it's up to the UC team.
Do you have any requests?

@h-ohta
Copy link
Contributor

h-ohta commented Mar 3, 2022

@kenji-miyake I got it. I also created PR for my vehicle. So I'd like to adjust the merge timing.

@kenji-miyake
Copy link
Contributor Author

@h-ohta It's great! But we have to care about other vehicles as well.

s-azumi pushed a commit to s-azumi/autoware_launch that referenced this pull request Apr 21, 2022
@kenji-miyake
Rename AstarNavi to FreespacePlannerNode (tier4#213)
9f6555a 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@kenji-miyake kenji-miyake changed the base branch from tier4/universe to awf-sync May 20, 2022 06:28
takayuki5168 pushed a commit that referenced this pull request May 26, 2022
@kenji-miyake
Rename AstarNavi to FreespacePlannerNode (#213)
0a4315b 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
takayuki5168 pushed a commit that referenced this pull request May 26, 2022
@kenji-miyake @hiro-ya-iv
@wep21 @k0suke-murakami @yamacir-kit @KeisukeShima @yk-fujii @s-azumi @taichiH @kmiya
Sync upstream (#80)
23e141a 
* Fix incorrect remap (#183)

* Fix incorrect remap

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Use set_remap

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add septentrio_gnss_driver launcher and switch(septentrio <-> ublox) (#196)

* add septentrio_gnss_driver launcher and switch(septentrio <-> ublox)

* rm arg(gnss_receiver) escalation and modify septentrio_gnss_driver_node option

* change gnss_receiver default septentrio to ublox

* remap all septentrio_gnss_driver topic names

* replace septentrio gnss driver launch type 'node' to 'include'

* Use set_parameter for use_sim_time (#198)

* Use set_parameter for use_sim_time

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add default parameter for scenario simulator

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* change system_monitor.launch.xml to launch.py (#203)

* Add control composed launch (#201)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add param for psim v2 (#197)

* add param for psim v2

Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp>

* Update to pass var 'scenario_simulation' to dummy_perception_publisher

* Update dummy_perception_publisher's arg-name

Co-authored-by: yamacir-kit <httperror@404-notfound.jp>

* Feature/porting v0.9.1 master (#202)

* add simulation arg (#174)

* add simulation arg

* add comment

* change arg name

* add parameter use_empty_dynamic_object_publisher into perception.launch (#176)

Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp>

Co-authored-by: Yusuke FUJII <yusuke.fujii@tier4.jp>
Co-authored-by: s-azumi <38061530+s-azumi@users.noreply.github.com>

* Fix mistakes in control.launch.py (#209)

* Fix typo in control.launch.py

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add remote_cmd_converter_component

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Feature/add external cmd selector (#206)

* Add remote_cmd_selector to control.launch (#172)

* Add remote_cmd_selector to control.launch

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename remote_cmd_selector to external_cmd_selector

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Change default external cmd source (#173)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* modify to use control.launch.xml

* add external_cmd_selector to control.launch.py

* Fix remapping in control.launch.py

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix remapping in control.launch.py again

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Keisuke Shima <keisuke.shima@tier4.jp>

* Add vehicle info launch for setting vehicle info param (#199)

* Add vehicle info launch for setting vehicle info param

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add comment for global parameters section

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix year and apply format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ready vehicle info param

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove vehicle info param server from logging simulator (#211)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add container launch for planning (#205)

* Add container launch for planning

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix porting miss

* fix lane_driving.launch.xml

* Add missing parameters

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: taichiH <azumade.30@gmail.com>

* Add map.launch.py (#212)

* Add map.launch.py

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Update map.launch.xml

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Rename parameter for lanelet2 map path

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Rename AstarNavi to FreespacePlannerNode (#213)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add spell check action (#214)

* Unify YAML file extension of GitHub action to yml (#216)

* Fix PR template (#218)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix PR template link (#219)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix minor typos in PULL_REQUEST_TEMPLATE.md (#222)

* Fix depends in localization_launch to exec_depend (#223)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add build CI (#224)

* Add build CI

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build_depend.repos

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add private repository settings

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove self repo

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Install pip

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Use packages-select and packages-up-to

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Change job name

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add build_and_test.yml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Install kvaser library

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Build only internal packages in CI (#227)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix typos in launch files (#231)

* Fix typos in launch files

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Format launch files (#228)

* Format launch files

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Format launch.py

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix lint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Exclude dummy_perception_publisher.launch.xml if is scenario_simulation (#230)

* Fix unresolved conflicts

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: hiro-ya-iv <30652835+hiro-ya-iv@users.noreply.github.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp>
Co-authored-by: yamacir-kit <httperror@404-notfound.jp>
Co-authored-by: Keisuke Shima <keisuke.shima@tier4.jp>
Co-authored-by: Yusuke FUJII <yusuke.fujii@tier4.jp>
Co-authored-by: s-azumi <38061530+s-azumi@users.noreply.github.com>
Co-authored-by: taichiH <azumade.30@gmail.com>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
takayuki5168 pushed a commit that referenced this pull request May 26, 2022
@satoshi-ota
Merge pull request #213 from tier4/sync-upstream-use-autoware-auto-msgs
578cd2d 
sync upstream use autoware auto msgs
maxime-clem pushed a commit that referenced this pull request May 27, 2022
@tkimura4
Merge pull request #213 from tier4/sync-upstream
ba18a8e 
chore: sync upstream
@kenji-miyake kenji-miyake deleted the split-vehicle-model-package branch October 30, 2022 05:23
@takayuki5168
Copy link
Contributor

@kenji-miyake Why was this PR closed?
You tried to make the directory structure of tier4's and awf's vehicle description/launch the same, right? I also want to realize it.

@kenji-miyake
Copy link
Contributor Author

@takayuki5168 Just because there were no comments from integration team members.
I can reopen it if you want, I have no resources to follow-up this PR. If you can take leadership, I really appreciate it.

@h-ohta h-ohta mentioned this pull request Nov 10, 2022
Merged
8 tasks
tier4-autoware-public-bot bot pushed a commit that referenced this pull request Feb 18, 2023
@takayuki5168
feat(autoware_launch): update rviz and rtc config for planning (#213)
3f43a14 
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
This was referenced Feb 20, 2023
Merged
Merged
Merged
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Feb 20, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wep21 wep21 wep21 left review comments

@yukkysaito yukkysaito yukkysaito approved these changes

@h-ohta h-ohta Awaiting requested review from h-ohta

@tkimura4 tkimura4 Awaiting requested review from tkimura4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kenji-miyake @yukkysaito @h-ohta @takayuki5168 @wep21