feat!: split package into description and launch
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Also, we have to change other vehicles as well. |
wep21
reviewed
Feb 19, 2022
wep21
reviewed
Feb 19, 2022
f8b18bc to
a6eef2a
Compare
|
@kenji-miyake "!" in the title is typo? |
|
@wep21 No, it tells people there is a breaking change. |
|
@kenji-miyake I got it. Thanks! |
|
LGTM 👍 |
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
a6eef2a to
5bf627c
Compare
|
Rebased to resolve conflicts. |
|
I'll close and make another PR to do same thing for latest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this breaks the package paths written in
autoware_launch, we need to merge the PR toautoware_launchat the same time.Related: tier4/autoware_launch#213