Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pid_longitudinal_controller): transit to STOPPED even if the sign of the ego velocity goes opposite #926

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

takayuki5168
Copy link

@takayuki5168 takayuki5168 commented Oct 10, 2023

Description

ずり下がり防止対応のうちの1つ
https://tier4.atlassian.net/browse/RT0-28971
https://tier4.atlassian.net/browse/RT0-29231

DRIVEの状態で停止しきらずにずり下がると永遠にSTOPPEDへ移行できない不具合修正
cherry-pick of autowarefoundation#5255

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 takayuki5168 force-pushed the fix/move-backward-on-steep-slope-beta branch from f067ab5 to 85156de Compare October 16, 2023 06:29
@mkuri mkuri self-requested a review October 18, 2023 12:01
…n of the ego velocity goes opposite (autowarefoundation#5255)

* feat(pid_longitudinal_controller): transit to STOPPED even if the sign of the ego velocity goes opposite

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* pid_longitudinal_controller.cpp を更新

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@takayuki5168 takayuki5168 force-pushed the fix/move-backward-on-steep-slope-beta branch from 4c65974 to e480966 Compare October 18, 2023 12:07
@takayuki5168 takayuki5168 merged commit 0d28913 into beta/v0.11.0 Oct 18, 2023
@takayuki5168 takayuki5168 deleted the fix/move-backward-on-steep-slope-beta branch October 18, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants