Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): prevent crashes with the drivable area expansion #916

Conversation

maxime-clem
Copy link

Description

This PR add a guards for when the boost::geometry::buffer function returns an empty set of polygons.

Tests performed

Not applicable.

Effects on system behavior

Prevents some crashes of the behavior_path_planner.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

PhoebeWu21 and others added 30 commits August 30, 2023 08:35
…efoundation#4663)

* refactor(radar_fusion_to_detected_object): rework parameters

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>

* style(pre-commit): autofix

* style(pre-commit): autofix

* style(pre-commit): autofix

---------

Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Satoshi Tanaka <16330533+scepter914@users.noreply.github.com>
…dency (autowarefoundation#4814)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
…n#4807)

* first commit

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* update

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* update height.cpp

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* updat

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* add test

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* revert tier4_autoware_utils

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* fix cspell

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove and revert convert.cpp

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove boost

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* update comment

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove maybe_unsued

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* rename from tier4_geography_utils to geography_utils

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* rename from tier4_geography_utils to geography_utils

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* add some test

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* edit test

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* rename namespace

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* rename namespace complete

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* use angle brackets inclusion

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…sed depending on the case (autowarefoundation#4813)

* feat(dynamic_avoidance): generate drivable area by ego/object-path-based depending on the case

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* apply clang-format

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
add maintainer

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…ion#4810)

rafactor(goal_planner): remove unncecessary variable

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
…utowarefoundation#4484)

* refactor(behavior_path_planner): scene module interface clang-tidy

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…utowarefoundation#4798)

* refactor(behavior_path_plannner): commonize collision check markers

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Update planning/behavior_path_planner/src/marker_utils/utils.cpp

Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
fix error msg

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…undation#4829)

removed tier4_autoware_utils.hpp in vehicle/

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
… lines (autowarefoundation#4710)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
… explanation (autowarefoundation#4834)

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
…oundation#4656)

* feat: add feature to convert json schema to markdown table

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>

* fix: fix typo

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>

* style(pre-commit): autofix

* fix: rename main.py and add some comments for the file

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>

* style(pre-commit): autofix

* fix: use simplified symbols for minimum and maximum

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>

* fix: Capitalize the first letter in columns' headers

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>

---------

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…4827)

removed motion_utils.hpp in common/

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
* feat(interface): add new option last_keep

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(planner_manager): keep last module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* update param config

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: kosuke55 <kosuke.tnp@gmail.com>
…ion (autowarefoundation#4677)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
…ation#4761)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
…ndation#4828)

removed tier4_autoware_utils.hpp in common/

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…dule cooperation (autowarefoundation#4836)

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.