feat(geography_utils): add geography_utils package #4807

kminoda · 2023-08-30T02:03:30Z

Description

Add tier4_geography_utils and use that in gnss_poser and default_ad_api to convert between vertical datums.

Tests performed

All the tests in tier4_geography_utils passes
Logging simulator works, and the output of gnss_poser and default_ad_api is successfully published

Notes for reviewers

None

Interface changes

NOne

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.
The PR has been properly tested.
The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.
The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>

system/default_ad_api/src/vehicle.cpp

Signed-off-by: kminoda <koji.minoda@tier4.jp>

codecov · 2023-08-30T08:46:06Z

Codecov Report

Patch coverage: 40.81% and project coverage change: +0.02% 🎉

Comparison is base (56c4585) 15.12% compared to head (8c6537e) 15.14%.
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4807      +/-   ##
==========================================
+ Coverage   15.12%   15.14%   +0.02%     
==========================================
  Files        1571     1573       +2     
  Lines      108229   108187      -42     
  Branches    33224    33217       -7     
==========================================
+ Hits        16365    16386      +21     
+ Misses      74033    73962      -71     
- Partials    17831    17839       +8

Flag	Coverage Δ		*Carryforward flag
differential	`13.07% <40.81%> (?)`
total	`15.13% <ø> (+0.01%)`	⬆️	Carriedforward from 283b351

*This pull request uses carry forward flags. Click here to find out more.

Files Changed	Coverage Δ
...de/radar_object_fusion_to_detected_object_node.cpp	`0.00% <ø> (ø)`
...behavior_velocity_crosswalk_module/src/manager.cpp	`11.65% <ø> (+0.22%)`	⬆️
..._velocity_crosswalk_module/src/scene_crosswalk.cpp	`0.00% <ø> (ø)`
..._velocity_crosswalk_module/src/scene_crosswalk.hpp	`0.00% <ø> (ø)`
...avior_velocity_intersection_module/src/manager.cpp	`18.75% <ø> (-0.12%)`	⬇️
...ity_intersection_module/src/scene_intersection.cpp	`0.00% <ø> (ø)`
...ity_intersection_module/src/scene_intersection.hpp	`0.00% <ø> (ø)`
...behavior_velocity_intersection_module/src/util.cpp	`0.00% <ø> (ø)`
...ior_velocity_intersection_module/src/util_type.hpp	`0.00% <ø> (ø)`
sensing/gnss_poser/include/gnss_poser/convert.hpp	`0.00% <0.00%> (ø)`
... and 3 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

isamu-takagi

LGTM (default_ad_api)

YamatoAndo

LGTM (gnss_poser)

…n#4807) * first commit Signed-off-by: kminoda <koji.minoda@tier4.jp> * update Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * update height.cpp Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * updat Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * add test Signed-off-by: kminoda <koji.minoda@tier4.jp> * revert tier4_autoware_utils Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * fix cspell Signed-off-by: kminoda <koji.minoda@tier4.jp> * remove and revert convert.cpp Signed-off-by: kminoda <koji.minoda@tier4.jp> * remove boost Signed-off-by: kminoda <koji.minoda@tier4.jp> * update comment Signed-off-by: kminoda <koji.minoda@tier4.jp> * remove maybe_unsued Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * rename from tier4_geography_utils to geography_utils Signed-off-by: kminoda <koji.minoda@tier4.jp> * rename from tier4_geography_utils to geography_utils Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * add some test Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * edit test Signed-off-by: kminoda <koji.minoda@tier4.jp> * rename namespace Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * rename namespace complete Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * use angle brackets inclusion Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

kminoda added 2 commits August 30, 2023 09:30

first commit

10cbe93

Signed-off-by: kminoda <koji.minoda@tier4.jp>

update

765da17

Signed-off-by: kminoda <koji.minoda@tier4.jp>

github-actions bot added component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:system System design and integration. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Aug 30, 2023

pre-commit-ci bot and others added 3 commits August 30, 2023 02:05

style(pre-commit): autofix

c09732d

update height.cpp

149bfe7

Signed-off-by: kminoda <koji.minoda@tier4.jp>

style(pre-commit): autofix

5d087fb

kminoda changed the title ~~feat(tier4_autoware_utils): add height system converter~~ feat(tier4_geography_utils): add height system converter Aug 30, 2023

kminoda and others added 3 commits August 30, 2023 14:57

updat

118bf56

Signed-off-by: kminoda <koji.minoda@tier4.jp>

style(pre-commit): autofix

b64192c

add test

fd50361

Signed-off-by: kminoda <koji.minoda@tier4.jp>

github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Aug 30, 2023

revert tier4_autoware_utils

247f2a3

Signed-off-by: kminoda <koji.minoda@tier4.jp>

kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 30, 2023

kminoda and others added 5 commits August 30, 2023 15:05

Merge branch 'main' into feat/add_height_system_converter

10d70d3

style(pre-commit): autofix

d4617ca

fix cspell

140131a

Signed-off-by: kminoda <koji.minoda@tier4.jp>

remove and revert convert.cpp

9a89e01

Signed-off-by: kminoda <koji.minoda@tier4.jp>

remove boost

df2b65e

Signed-off-by: kminoda <koji.minoda@tier4.jp>

kminoda marked this pull request as ready for review August 30, 2023 06:24

kminoda requested review from isamu-takagi, tkhmy, yabuta, mitsudome-r, yukkysaito and YamatoAndo as code owners August 30, 2023 06:24

kminoda and others added 3 commits August 30, 2023 15:31

update comment

aa5ee45

Signed-off-by: kminoda <koji.minoda@tier4.jp>

remove maybe_unsued

d59675d

Signed-off-by: kminoda <koji.minoda@tier4.jp>

style(pre-commit): autofix

d0dd3cb

kminoda and others added 5 commits August 30, 2023 15:47

rename from tier4_geography_utils to geography_utils

ba19c12

Signed-off-by: kminoda <koji.minoda@tier4.jp>

rename from tier4_geography_utils to geography_utils

3701f7d

Signed-off-by: kminoda <koji.minoda@tier4.jp>

style(pre-commit): autofix

60c0e01

add some test

b9477f6

Signed-off-by: kminoda <koji.minoda@tier4.jp>

style(pre-commit): autofix

77b77bd

kminoda changed the title ~~feat(tier4_geography_utils): add height system converter~~ feat(geography_utils): add height system converter Aug 30, 2023

kminoda changed the title ~~feat(geography_utils): add height system converter~~ feat(geography_utils): add geography_utils package Aug 30, 2023

kminoda and others added 6 commits August 30, 2023 16:00

edit test

564abfb

Signed-off-by: kminoda <koji.minoda@tier4.jp>

rename namespace

68cd3d1

Signed-off-by: kminoda <koji.minoda@tier4.jp>

style(pre-commit): autofix

8fe6e2c

rename namespace complete

8698b22

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Merge branch 'main' into feat/add_height_system_converter

c0a7aaa

style(pre-commit): autofix

283b351

isamu-takagi reviewed Aug 30, 2023

View reviewed changes

system/default_ad_api/src/vehicle.cpp Outdated Show resolved Hide resolved

use angle brackets inclusion

9068e1b

Signed-off-by: kminoda <koji.minoda@tier4.jp>

pre-commit-ci bot and others added 2 commits August 30, 2023 08:47

style(pre-commit): autofix

caf9afa

Merge branch 'main' into feat/add_height_system_converter

8c6537e

isamu-takagi approved these changes Aug 30, 2023

View reviewed changes

YamatoAndo approved these changes Aug 30, 2023

View reviewed changes

kminoda enabled auto-merge (squash) August 30, 2023 09:18

kminoda merged commit 812910a into autowarefoundation:main Aug 30, 2023

tier4-autoware-public-bot bot mentioned this pull request Aug 31, 2023

chore: sync upstream tier4/autoware.universe#781

Merged

kminoda deleted the feat/add_height_system_converter branch September 26, 2023 01:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(geography_utils): add geography_utils package #4807

feat(geography_utils): add geography_utils package #4807

kminoda commented Aug 30, 2023 •

edited

Loading

codecov bot commented Aug 30, 2023 •

edited

Loading

isamu-takagi left a comment

YamatoAndo left a comment

feat(geography_utils): add geography_utils package #4807

feat(geography_utils): add geography_utils package #4807

Conversation

kminoda commented Aug 30, 2023 • edited Loading

Description

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

codecov bot commented Aug 30, 2023 • edited Loading

Codecov Report

isamu-takagi left a comment

Choose a reason for hiding this comment

YamatoAndo left a comment

Choose a reason for hiding this comment

kminoda commented Aug 30, 2023 •

edited

Loading

codecov bot commented Aug 30, 2023 •

edited

Loading