Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(control_validator): fix error msg #4794

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Aug 29, 2023

Description

🤖 Generated by Copilot at ebf5295

Updated the warning message in control_validator.cpp to match the validation logic. This change enhances the user experience and avoids confusion.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Aug 29, 2023
@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (7a4a905) 15.11% compared to head (ebf5295) 15.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4794      +/-   ##
==========================================
- Coverage   15.11%   15.11%   -0.01%     
==========================================
  Files        1568     1568              
  Lines      108176   108177       +1     
  Branches    33218    33218              
==========================================
  Hits        16346    16346              
- Misses      74013    74014       +1     
  Partials    17817    17817              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.11% <ø> (+<0.01%) ⬆️ Carriedforward from 7a4a905

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ontrol/control_validator/src/control_validator.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara merged commit 3dd38de into autowarefoundation:main Aug 31, 2023
@kyoichi-sugahara kyoichi-sugahara deleted the fix/control_validator_error_msg branch September 27, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants