Make spaces in separator configurable #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thombashi
requested changes
Aug 6, 2022
| @@ -836,7 +836,7 @@ def __normalize_datetime_value(self, value, timezone): | |||
| def from_range_text( | |||
| cls, | |||
| range_text: str, | |||
| separator: str = "-", | |||
| separator: str = " - ", | |||
There was a problem hiding this comment.
This is not exactly equivalent to the current behavior.
How about make it possible to specify a separator as a regular expression.
This will allows for more flexible designations.
thombashi
added a commit
that referenced
this pull request
Feb 11, 2023
…nge_text method: #41 Co-authored-by: Felix Delattre <felix.delattre@up42.com>
|
Since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
from_range_text()allows to define the separator, but has hardcoded spaces around them. This is not always the case (see as an example, the STAC api specs datetime uses ).Suggesting to remove the hardcoded spaces and make them configurable through the
separatorargument.