Modify to accept regular expression for separator argument of from_ra…

…nge_text method: #41 Co-authored-by: Felix Delattre <felix.delattre@up42.com>
thombashi · Feb 11, 2023 · 6976a8c · 6976a8c
1 parent 0ce0c2d
commit 6976a8c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/datetimerange/__init__.py b/datetimerange/__init__.py
@@ -853,7 +853,7 @@ def __normalize_datetime_value(self, value, timezone):
     def from_range_text(
         cls,
         range_text: str,
-        separator: str = "-",
+        separator: str = r"\s+\-\s+",
         start_time_format: Optional[str] = None,
         end_time_format: Optional[str] = None,
     ) -> "DateTimeRange":
@@ -864,13 +864,13 @@ def from_range_text(
             e.g. ``2021-01-23T10:00:00+0400 - 2021-01-232T10:10:00+0400``
 
         :param str separator:
-            Text that separating the ``range_text``.
+            Regular expression that separating the ``range_text`` to start and end time.
 
         :return: DateTimeRange
             Created instance.
         """
 
-        dattime_ranges = re.split(rf"\s+{re.escape(separator)}\s+", range_text.strip())
+        dattime_ranges = re.split(separator, range_text.strip())
         if len(dattime_ranges) != 2:
             raise ValueError("range_text should include two datetime that separated by hyphen")
 

diff --git a/test/test_dtr.py b/test/test_dtr.py
@@ -1242,7 +1242,7 @@ class TestDateTimeRange_from_range_text:
         [
             [
                 f"{START_DATETIME_TEXT} - {END_DATETIME_TEXT}",
-                "-",
+                r"\s+\-\s+",
                 DateTimeRange(START_DATETIME_TEXT, END_DATETIME_TEXT),
             ],
             [
@@ -1252,7 +1252,7 @@ class TestDateTimeRange_from_range_text:
             ],
             [
                 f"{START_DATETIME_TEXT}  -  {END_DATETIME_TEXT}",
-                "-",
+                r"\s+\-\s+",
                 DateTimeRange(START_DATETIME_TEXT, END_DATETIME_TEXT),
             ],
         ],