Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make spaces in separator configurable #41

Closed
wants to merge 1 commit into from
Closed

Make spaces in separator configurable #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions datetimerange/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,7 +836,7 @@ def __normalize_datetime_value(self, value, timezone):
def from_range_text(
cls,
range_text: str,
separator: str = "-",
separator: str = " - ",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not exactly equivalent to the current behavior.
How about make it possible to specify a separator as a regular expression.
This will allows for more flexible designations.

start_time_format: Optional[str] = None,
end_time_format: Optional[str] = None,
) -> "DateTimeRange":
Expand All @@ -853,7 +853,7 @@ def from_range_text(
Created instance.
"""

dattime_ranges = re.split(r"\s+{}\s+".format(re.escape(separator)), range_text.strip())
dattime_ranges = re.split(r"{}".format(re.escape(separator)), range_text.strip())
if len(dattime_ranges) != 2:
raise ValueError("range_text should include two datetime that separated by hyphen")

Expand Down