Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-parsing events #427

Merged
merged 1 commit into from
Apr 13, 2020
Merged

Pre-parsing events #427

merged 1 commit into from
Apr 13, 2020

Conversation

neochief
Copy link
Contributor

@neochief neochief commented Apr 7, 2020

I have a site with a huge amount of markdown content that uses inline references extensively. Prior to 0.19 I was able to implement reference map caching by overriding DocParser, but now it's final, so it's no longer possible.

It seems that the ability to pre-fill the reference map was envisioned from the very beginning (#359), so this pull request is a basic attempt to make it happen with events.

@colinodell
Copy link
Member

This looks great! And it's a perfect use of the new event system :)

However, I do need to complete #428 first so that we can document new features like this one (and #420) in the proper location. I'll plan to tackle that this week so we can rebase this and target the 1.4 docs instead.

@colinodell colinodell self-requested a review April 8, 2020 02:12
@colinodell colinodell self-assigned this Apr 8, 2020
@colinodell colinodell added the enhancement New functionality or behavior label Apr 8, 2020
@colinodell colinodell added this to the v1.4.0 milestone Apr 8, 2020
@neochief
Copy link
Contributor Author

neochief commented Apr 8, 2020

Awesome, thanks!

Copy link
Member

@colinodell colinodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@colinodell colinodell merged commit 50ca8ad into thephpleague:master Apr 13, 2020
This was linked to issues Apr 13, 2020
@colinodell colinodell linked an issue Apr 13, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New functionality or behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for events [RFC] Event dispatcher
2 participants