Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Event dispatcher #359

Closed
colinodell opened this issue Apr 20, 2019 · 3 comments · Fixed by #427
Closed

[RFC] Event dispatcher #359

colinodell opened this issue Apr 20, 2019 · 3 comments · Fixed by #427
Assignees
@colinodell
Labels
discussion Open discussion about a particular feature or proposed change enhancement New functionality or behavior feedback wanted We need your input!
Milestone
v1.0

Comments

@colinodell
Copy link
Member

Let's consider adding support for an (optional) event dispatcher which would allow people to hook into certain private methods. For example, somebody may want to pre-populate references on the Document before we begin parsing. This is not currently possible as we create that node and begin parsing within a private method. Adding support for something like PSR-14 would make it easy for others to hook into this type of logic.
@colinodell colinodell added enhancement New functionality or behavior feedback wanted We need your input! discussion Open discussion about a particular feature or proposed change labels Apr 20, 2019
@colinodell colinodell self-assigned this Apr 20, 2019
@colinodell colinodell mentioned this issue Apr 20, 2019
Closed
10 tasks
@colinodell
Copy link
Member Author

Marking this as a possible 2.0 feature - there's no demand for this yet and I'd like to better see how PSR-14 is accepted by the community before committing to a certain way of doing things.

@colinodell colinodell added this to the v2.0 milestone May 25, 2019
@colinodell colinodell modified the milestones: v2.0, v1.0 Jun 4, 2019
@colinodell
Copy link
Member Author

Just kidding, let's target 1.0 via #372

@colinodell
Copy link
Member Author

Implemented via #372

@neochief neochief mentioned this issue Apr 7, 2020
Merged
@colinodell colinodell linked a pull request Apr 13, 2020 that will close this issue
Pre-parsing events #427
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colinodell colinodell

Labels
discussion Open discussion about a particular feature or proposed change enhancement New functionality or behavior feedback wanted We need your input!
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

Pre-parsing events
1 participant
@colinodell