Implement event dispatching #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3c159c1 to
e6a6ba3
Compare
GrahamCampbell
suggested changes
Jun 4, 2019
65e53b5 to
6d1fdb1
Compare
6d1fdb1 to
ad51a80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of saving this for 2.0, I think it would be very helpful if 1.0 had a generic way to add future "hooks" into the library without needing to break backward compatibility - a basic event dispatcher implementation like this should do the trick.
I considering using PSR-14, but that would require bumping the minimum PHP version to 7.2, which I'm not interested in doing at this time - many people are using this on PHP 7.1 and I want to ensure they have a stable release too. I also considered pulling in symfony/event-dispatcher but we only need a basic implementation for now. We can re-evaluate these choices in 2.0.