Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new heading permalink extension #420

Merged
merged 1 commit into from
Apr 11, 2020
Merged

Implement new heading permalink extension #420

merged 1 commit into from
Apr 11, 2020

Conversation

colinodell
Copy link
Member

@colinodell colinodell commented Apr 4, 2020 •
edited
Loading

New extension which automatically adds anchor links to headings, similar to Github:

image

Documentation: https://github.com/thephpleague/commonmark/blob/heading-link-extension/docs/1.3/extensions/heading-permalinks.md

@colinodell colinodell added the enhancement New functionality or behavior label Apr 4, 2020
@colinodell colinodell self-assigned this Apr 4, 2020
@colinodell colinodell force-pushed the heading-link-extension branch from 37ee196 to 1143eb7 Compare April 4, 2020 14:41
@mfn mfn mentioned this pull request Apr 4, 2020
Closed
@colinodell colinodell force-pushed the heading-link-extension branch 4 times, most recently from 62ffa84 to 9a022e1 Compare April 5, 2020 23:45
@colinodell colinodell changed the title Implement new heading link extension Implement new heading permalink extension Apr 5, 2020
@colinodell
Copy link
Member Author

I've just force-pushed a few changes:

Any feedback would be appreciated!

@colinodell colinodell mentioned this pull request Apr 8, 2020
Merged
@colinodell colinodell added this to the v1.4.0 milestone Apr 8, 2020
@colinodell colinodell force-pushed the heading-link-extension branch from 9a022e1 to 48a482f Compare April 11, 2020 15:59
@colinodell colinodell force-pushed the heading-link-extension branch from 48a482f to f7308a3 Compare April 11, 2020 16:08
@colinodell colinodell merged commit 3741f7a into master Apr 11, 2020
@colinodell colinodell deleted the heading-link-extension branch April 11, 2020 19:00
@glensc
Copy link
Contributor

glensc commented Apr 19, 2020

both links here point to 1.3, but I think they got released as 1.4 and there's no redirection, so the links are borken.

@glensc glensc mentioned this pull request Apr 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@colinodell colinodell

Labels
enhancement New functionality or behavior
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@colinodell @glensc