minifier should not skip callee in more cases

[kdy1]

Describe the bug

Related to #6044

If an expression has a side effect on the identifier in the callee position, this is not caught by the infection analysis.

We can fix this by aborting on reassignments to the callee, and this seems better.
(This resulted in a too much regression)

Input code

let foo = () => 1;

const obj = {
    get 0() {
        foo = () => 2;
        return 40;
    },
};
console.log(obj)

var c = obj[0];

console.log(foo(c));

Config

{
  "jsc": {
    "parser": {
      "syntax": "ecmascript",
      "jsx": false
    },
    "target": "es2022",
    "loose": false,
    "minify": {
      "compress": {
        "arguments": false,
        "arrows": true,
        "booleans": true,
        "booleans_as_integers": false,
        "collapse_vars": true,
        "comparisons": true,
        "computed_props": true,
        "conditionals": true,
        "dead_code": true,
        "directives": true,
        "drop_console": false,
        "drop_debugger": true,
        "evaluate": true,
        "expression": false,
        "hoist_funs": false,
        "hoist_props": true,
        "hoist_vars": false,
        "if_return": true,
        "join_vars": true,
        "keep_classnames": false,
        "keep_fargs": true,
        "keep_fnames": false,
        "keep_infinity": false,
        "loops": true,
        "negate_iife": true,
        "properties": true,
        "reduce_funcs": false,
        "reduce_vars": false,
        "side_effects": true,
        "switches": true,
        "typeofs": true,
        "unsafe": false,
        "unsafe_arrows": false,
        "unsafe_comps": false,
        "unsafe_Function": false,
        "unsafe_math": false,
        "unsafe_symbols": false,
        "unsafe_methods": false,
        "unsafe_proto": false,
        "unsafe_regexp": false,
        "unsafe_undefined": false,
        "unused": true,
        "const_to_let": true,
        "pristine_globals": true
      },
      "mangle": false
    }
  },
  "module": {
    "type": "es6"
  },
  "minify": false,
  "isModule": true
}

Playground link

https://play.swc.rs/?version=1.3.4&code=H4sIAAAAAAAAA8tJLVFIy89XsFXQ0FSwtVMwtObiSs7PKy5RyE%2FKAopWcykAQTpQlQFQAYQHAsh6jKzhwkWpJaVFeQomBhChWh2uWmuwefk5qXo5%2BekaQFM1ubjKEosUkoH6gbxog1iolTAlQKM1kjU1rQG1tv8ymwAAAA%3D%3D&config=H4sIAAAAAAAAA22TQZLjIAxF7%2BJ1FlNZ9KIPMLs%2BA6WAcOjByIVEOq5U7j7CsXGc9M56%2FhLiS9y6b7bd560bITPm%2BsVTErh2nx3aAdjmMEp3UJkiD5HxfugEco9SJXz8czzq70jEuAgO3RBS8FMtZmkYMzLXb00qAybhpoOc6UdDyUWjE1FESG%2BxATYhCfaYt1RLMcLIaC6QW0Y9DXJgSjtUBJ0ZM41PNLkggZIWW5lDcMaSwwZCRivhgptEa6gksTbWOpmhw1Pp%2B2rgQ4kXiAWk1cLrbIOe2PLOFFiML4lf0K7TB3pcclEFbzJKyWnVfFNIOx%2F%2BIWqfEZgTDLhlztzrHPZK%2F4sqJK9DlKlRnfDWVcJeL2dC8O2GtWvMEja3Mrpisd7QbsUXuLsQB4cGvVe3WzL%2FBLHnrZhMI5JvoboGfpvBIzTrPu1pXYE3%2BFe7kudxLHwAOb8ynoYTxbcSA8qZ3BtWI4ReYdbtvY6vtCSHajO6px%2BFa9jWVIcvZGJ9bavPuhCaY%2FpIp7a%2B%2BigHSH1by3sF5EoFt9m8%2BbV%2BdPftda7rxF%2BLcC70H9%2FRCH8SBAAA

Expected behavior

It should not be inlined.

Actual behavior

No response

Version

main

Additional context

No response

[Austaras]

A variant

let foo = () => 1;

const obj = new Proxy({}, {
    get () {
        foo = () => 2;
        return 40;
    },
});
console.log(obj)

var c = obj[0];

console.log(foo(c));

[swc-bot]

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.