-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(es/minifier): Abort sequential inliner on reassigned identifier #6048
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like many are caused by unresolved idents, maybe we could fix #6049 first? |
I'll try |
There are still lots of regressions |
Oh, I mean we should stop at where callee is reassigned |
Ah, thank you! |
It didn't work, and actually we were not skipping callee anyway |
Well basically I thought it should be // sequences.rs#1530
Expr::Call(CallExpr {
callee: Callee::Expr(b_callee),
args: b_args,
..
}) => {
let is_this_undefined = b_callee.is_ident();
trace_op!("seq: Try callee of call");
if let Expr::Ident(i) = &**b_callee {
if let Some(usage) = self.data.vars.get(&i.to_id()) {
if usage.reassigned() {
return Ok(false);
}
}
} But that would cause lots of regressions too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
cc @Austaras
I think we should fix this by improving infection analysis, as regression is way too much
Related issue: