-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(es/minifier): Don't track usage assign #6044
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Oh, sorry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we are proving these facts.
I added two-way infection, which is clearly not optimal, because it prevents bugs
Yeah, if |
The difference can be run down to https://github.com/terser/terser/blob/master/lib/compress/tighten-body.js#L887. It checks if it's a AST_SymbolDefun(definition of function) or defined in current scope, which I believe is just a convenient implementation. |
Oh... It's bit shocking but if so I think this PR is fine |
So basically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Description:
Don't know if it's right, but it generate correct output.
BREAKING CHANGE:
Related issue (if exists):