Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing resources for diagnose #1130

Closed
wants to merge 1 commit into from
Closed

Add missing resources for diagnose #1130

wants to merge 1 commit into from

Conversation

skitt
Copy link
Member

@skitt skitt commented May 15, 2024 •
edited
Loading

This is only used to verify submariner-io/submariner-operator#3067. The real update is handled by #1128.

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1130/skitt/missing-diagnose-rbac
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@skitt skitt mentioned this pull request May 15, 2024
Merged
@skitt skitt force-pushed the missing-diagnose-rbac branch 4 times, most recently from ed91277 to 41aec3e Compare May 15, 2024 15:59
@skitt
Add missing resources for diagnose
a366d9f 
Signed-off-by: Stephen Kitt <skitt@redhat.com>
@skitt skitt force-pushed the missing-diagnose-rbac branch from 41aec3e to a366d9f Compare May 15, 2024 16:20
@skitt skitt mentioned this pull request May 15, 2024
Merged
@skitt skitt marked this pull request as draft May 16, 2024 07:58
@dfarrell07 dfarrell07 added the ready-to-test When a PR is ready for full E2E testing label May 16, 2024
@tpantelis tpantelis closed this May 21, 2024
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr1130/skitt/missing-diagnose-rbac]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aswinsuryan aswinsuryan Awaiting requested review from aswinsuryan aswinsuryan is a code owner

@dfarrell07 dfarrell07 Awaiting requested review from dfarrell07 dfarrell07 is a code owner

@Jaanki Jaanki Awaiting requested review from Jaanki Jaanki is a code owner

@maayanf24 maayanf24 Awaiting requested review from maayanf24 maayanf24 is a code owner

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

@tpantelis tpantelis Awaiting requested review from tpantelis tpantelis is a code owner

@vthapar vthapar Awaiting requested review from vthapar vthapar is a code owner

Assignees
No one assigned
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skitt @submariner-bot @dfarrell07 @tpantelis